build.webkit.org/dashboard: Combined queues don't turn orange on internal failure

https://bugs.webkit.org/show_bug.cgi?id=148356

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@188838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js
index 8f32222..fa96e00 100644 (file)
--- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js
+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js
@@ -106,14 +106,15 @@ BuildbotCombinedQueueView.prototype = {
                 if (firstRecentUnsuccessfulIteration && firstRecentUnsuccessfulIteration.loaded && mostRecentFinishedIteration && mostRecentFinishedIteration.loaded) {
                     console.assert(!mostRecentFinishedIteration.successful);
                     var message = this.revisionContentForIteration(mostRecentFinishedIteration, mostRecentFinishedIteration.productive ? mostRecentSuccessfulIteration : null);
-                    if (mostRecentFinishedIteration.failed) {
+                    if (!mostRecentFinishedIteration.productive)
+                        var status = StatusLineView.Status.Danger;
+                    else {
                         // Direct links to some common logs.
                         var url = mostRecentFinishedIteration.failureLogURL("build log");
                         if (!url)
                             url = mostRecentFinishedIteration.failureLogURL("stdio");
                         var status = StatusLineView.Status.Bad;
-                    } else
-                        var status = StatusLineView.Status.Danger;
+                    }
 
                     // Show a popover when the URL is not a main build page one, because there are usually multiple logs, and it's good to provide a choice.
                     var needsPopover = !url;

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index e175369..276ec80 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,5 +1,15 @@
 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
 
+        build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
+        https://bugs.webkit.org/show_bug.cgi?id=148356
+
+        Reviewed by Darin Adler.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
+        (BuildbotCombinedQueueView.prototype.update):
+
+2015-08-23  Alexey Proskuryakov  <ap@apple.com>
+
         build.webkit.org/dashboard: Respect step's hidden flag
         https://bugs.webkit.org/show_bug.cgi?id=148357