Add a WinCairo EWS queue
authordon.olmstead@sony.com <don.olmstead@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 7 Nov 2017 22:38:34 +0000 (22:38 +0000)
committerdon.olmstead@sony.com <don.olmstead@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 7 Nov 2017 22:38:34 +0000 (22:38 +0000)
https://bugs.webkit.org/show_bug.cgi?id=179390

Reviewed by Lucas Forschler.

* QueueStatusServer/config/queues.py:
* QueueStatusServer/model/queues.py:
* Scripts/webkitpy/common/config/ews.json:
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/config/ports_unittest.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/QueueStatusServer/config/queues.py
Tools/QueueStatusServer/model/queues.py
Tools/Scripts/webkitpy/common/config/ews.json
Tools/Scripts/webkitpy/common/config/ports.py
Tools/Scripts/webkitpy/common/config/ports_unittest.py
Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py

index 5468724..02c1b88 100644 (file)
@@ -1,3 +1,17 @@
+2017-11-07  Don Olmstead  <don.olmstead@sony.com>
+
+        Add a WinCairo EWS queue
+        https://bugs.webkit.org/show_bug.cgi?id=179390
+
+        Reviewed by Lucas Forschler.
+
+        * QueueStatusServer/config/queues.py:
+        * QueueStatusServer/model/queues.py:
+        * Scripts/webkitpy/common/config/ews.json:
+        * Scripts/webkitpy/common/config/ports.py:
+        * Scripts/webkitpy/common/config/ports_unittest.py:
+        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+
 2017-11-07  Aakash Jain  <aakash_jain@apple.com>
 
         fix check-webkit-style errors in webkitpy about not having two spaces before inline comment
index 15aaae9..e766be8 100644 (file)
@@ -43,6 +43,7 @@ all_queue_names = [
     "mac-debug-ews",
     "mac-32bit-ews",
     "win-ews",
+    "wincairo-ews",
     "wpe-ews",
 ]
 
index 6c64da1..028c447 100644 (file)
@@ -81,6 +81,7 @@ class Queue(object):
         display_name = display_name.replace("Jsc", "JSC")
         display_name = display_name.replace("Wpe", "WPE")
         display_name = display_name.replace("Gtk", "GTK")
+        display_name = display_name.replace("Wincairo", "WinCairo")
         return display_name
 
     _dash_regexp = re.compile("-")
index 342a6f8..772f436 100644 (file)
         "runTests": true,
         "shouldBuild": false
     },
+    "WinCairo EWS": {
+        "port": "wincairo",
+        "name": "wincairo-ews",
+        "runTests": false,
+        "watchers": [
+            "SIE-WebKit-EWS@am.sony.com"
+        ]
+    },
     "WPE EWS": {
         "port": "wpe",
         "watchers": [
index d3dfdf3..c092132 100644 (file)
@@ -189,6 +189,12 @@ class WinPort(DeprecatedPort):
 class WinCairoPort(DeprecatedPort):
     port_flag_name = "wincairo"
 
+    def build_webkit_command(self, build_style=None):
+        command = super(WinCairoPort, self).build_webkit_command(build_style=build_style)
+        command.append('--wincairo')
+        command.append('--64-bit')
+        return command
+
 
 class GtkWK2Port(DeprecatedPort):
     port_flag_name = "gtk-wk2"
index 9e679e2..20f0e80 100644 (file)
@@ -55,3 +55,9 @@ class DeprecatedPortTest(unittest.TestCase):
         self.assertEqual(WpePort().run_webkit_tests_command(), DeprecatedPort().script_shell_command("run-webkit-tests") + ["--wpe"])
         self.assertEqual(WpePort().build_webkit_command(), DeprecatedPort().script_shell_command("build-webkit") + ["--wpe", "--update-wpe", DeprecatedPort().makeArgs()])
         self.assertEqual(WpePort().build_webkit_command(build_style="debug"), DeprecatedPort().script_shell_command("build-webkit") + ["--debug", "--wpe", "--update-wpe", DeprecatedPort().makeArgs()])
+
+    def test_wincairo_port(self):
+        self.assertEqual(WinCairoPort().flag(), "--port=wincairo")
+        self.assertEqual(WinCairoPort().run_webkit_tests_command(), DeprecatedPort().script_shell_command("run-webkit-tests") + ["--wincairo"])
+        self.assertEqual(WinCairoPort().build_webkit_command(), DeprecatedPort().script_shell_command("build-webkit") + ["--wincairo", "--64-bit", DeprecatedPort().makeArgs()])
+        self.assertEqual(WinCairoPort().build_webkit_command(build_style="debug"), DeprecatedPort().script_shell_command("build-webkit") + ["--debug", "--wincairo", "--64-bit", DeprecatedPort().makeArgs()])
index efdbf7b..6ecaed0 100644 (file)
@@ -204,6 +204,7 @@ MOCK: update_status: %(name)s Checked relevance of patch
             'webkitpy-ews',
             'win-ews',
             'wpe-ews',
+            'wincairo-ews',
         }
         classes = AbstractEarlyWarningSystem.load_ews_classes()
         names = {cls.name for cls in classes}