[Mac] Unreviewed test fix after r182581
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Apr 2015 03:42:04 +0000 (03:42 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Apr 2015 03:42:04 +0000 (03:42 +0000)
The behavior of control-left-click is controlled by a system preference.
Our test bots have this turned off.

* TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@182584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp
Tools/TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm

index 86f25ec..d3b6380 100644 (file)
@@ -1,5 +1,17 @@
 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
 
+        [Mac] Unreviewed test fix after r182581
+
+        The behavior of control-left-click is controlled by a system preference.
+        Our test bots have this turned off.
+
+        * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
+        (TestWebKitAPI::TEST):
+
+2015-04-08  Brent Fulgham  <bfulgham@apple.com>
+
         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
         https://bugs.webkit.org/show_bug.cgi?id=143452
         <rdar://problem/20437483>
index f77a11a..bb98002 100644 (file)
@@ -86,7 +86,8 @@ TEST(WebKit2, MenuAndButtonForNormalMiddleClick)
 
 TEST(WebKit2, MenuAndButtonForControlLeftClick)
 {
-    buildAndPerformTest(kWKEventMouseButtonLeftButton, kWKEventModifiersControlKey, "0", "context");
+    // Note: This is controlled by a Mouse system preference. Check settings if this is failing.
+    buildAndPerformTest(kWKEventMouseButtonLeftButton, kWKEventModifiersControlKey, "0", "none");
 }
 
 TEST(WebKit2, MenuAndButtonForControlRightClick)
index 03f0f74..0b0d305 100644 (file)
@@ -78,7 +78,8 @@ TEST(WebKit1, MenuAndButtonForNormalMiddleClick)
 
 TEST(WebKit1, MenuAndButtonForControlLeftClick)
 {
-    buildAndPerformTest(NSLeftMouseDown, NSControlKeyMask, WebCore::LeftButton, NSMenuTypeContextMenu);
+    // Note: This is controlled by a Mouse system preference. Check settings if this is failing.
+    buildAndPerformTest(NSLeftMouseDown, NSControlKeyMask, WebCore::LeftButton, NSMenuTypeNone);
 }
 
 TEST(WebKit1, MenuAndButtonForControlRightClick)