[iOS] simctl can hang if run quickly after shutting down CoreSimulator services
authordfarler@apple.com <dfarler@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Aug 2014 01:07:09 +0000 (01:07 +0000)
committerdfarler@apple.com <dfarler@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Aug 2014 01:07:09 +0000 (01:07 +0000)
https://bugs.webkit.org/show_bug.cgi?id=135626

Reviewed by Dan Bernstein.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.setup_test_run):
Remove call to simctl shutdown <device> - telling the simulator app to quit
will shut down all booted devices.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/port/ios.py

index 39195aa..f136b1d 100644 (file)
@@ -1,3 +1,15 @@
+2014-08-05  David Farler  <dfarler@apple.com>
+
+        [iOS] simctl can hang if run quickly after shutting down CoreSimulator services
+        https://bugs.webkit.org/show_bug.cgi?id=135626
+
+        Reviewed by Dan Bernstein.
+
+        * Scripts/webkitpy/port/ios.py:
+        (IOSSimulatorPort.setup_test_run):
+        Remove call to simctl shutdown <device> - telling the simulator app to quit
+        will shut down all booted devices.
+
 2014-08-05  Alexey Proskuryakov  <ap@apple.com>
 
         Remove an unused argument from BuildbotQueue.update()
 2014-08-05  Alexey Proskuryakov  <ap@apple.com>
 
         Remove an unused argument from BuildbotQueue.update()
index b232898..6953c71 100644 (file)
@@ -186,7 +186,6 @@ class IOSSimulatorPort(Port):
 
     def setup_test_run(self):
         self._executive.run_command(['osascript', '-e', 'tell application "iOS Simulator" to quit'])
 
     def setup_test_run(self):
         self._executive.run_command(['osascript', '-e', 'tell application "iOS Simulator" to quit'])
-        self._executive.run_command([self.xcrun_find('simctl'), 'shutdown', self.simulator_udid()], error_handler=lambda e: None)
 
     def clean_up_test_run(self):
         super(IOSSimulatorPort, self).clean_up_test_run()
 
     def clean_up_test_run(self):
         super(IOSSimulatorPort, self).clean_up_test_run()