REGRESSION: Weak symbol warning when linking TestWebKitAPI
authorfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 25 Jun 2016 19:07:15 +0000 (19:07 +0000)
committerfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 25 Jun 2016 19:07:15 +0000 (19:07 +0000)
https://bugs.webkit.org/show_bug.cgi?id=159104

Reviewed by Dan Bernstein.

This uses a better approach to turn on -fvisility=hidden. All of the other projects set
this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".

* TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
* TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig
Tools/TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig
Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

index 316f792..760777c 100644 (file)
@@ -1,3 +1,17 @@
+2016-06-25  Filip Pizlo  <fpizlo@apple.com>
+
+        REGRESSION: Weak symbol warning when linking TestWebKitAPI
+        https://bugs.webkit.org/show_bug.cgi?id=159104
+
+        Reviewed by Dan Bernstein.
+        
+        This uses a better approach to turn on -fvisility=hidden. All of the other projects set
+        this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
+
+        * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
+        * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
+
 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
 
         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
index 04a1fce..edf1467 100644 (file)
                        isa = XCBuildConfiguration;
                        baseConfigurationReference = 7C83E0271D0A5B8D00FEBCF3 /* TestWTFLibrary.xcconfig */;
                        buildSettings = {
-                               OTHER_CPLUSPLUSFLAGS = (
-                                       "$(inherited)",
-                                       "-ftemplate-depth=256",
-                                       "-fvisibility=hidden",
-                               );
                        };
                        name = Debug;
                };
                        isa = XCBuildConfiguration;
                        baseConfigurationReference = 7C83E0271D0A5B8D00FEBCF3 /* TestWTFLibrary.xcconfig */;
                        buildSettings = {
-                               OTHER_CPLUSPLUSFLAGS = (
-                                       "$(inherited)",
-                                       "-ftemplate-depth=256",
-                                       "-fvisibility=hidden",
-                               );
                        };
                        name = Release;
                };