2009-02-24 Dimitri Glazkov <dglazkov@chromium.org>
authordglazkov@chromium.org <dglazkov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 25 Feb 2009 00:13:30 +0000 (00:13 +0000)
committerdglazkov@chromium.org <dglazkov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 25 Feb 2009 00:13:30 +0000 (00:13 +0000)
        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24141
        Add clarity to V8 interceptor helper function.

        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
        (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
        (WebCore::NAMED_PROPERTY_SETTER): Ditto.
        (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
        (WebCore::INDEXED_PROPERTY_SETTER): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp

index 79c844a..9900689 100644 (file)
@@ -1,3 +1,16 @@
+2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=24141
+        Add clarity to V8 interceptor helper function.
+
+        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
+        (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
+        (WebCore::NAMED_PROPERTY_SETTER): Ditto.
+        (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
+        (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
+
 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
 
         Reviewed by Eric Seidel
index 4cd19d2..a6e41a1 100644 (file)
@@ -48,11 +48,11 @@ NAMED_PROPERTY_GETTER(HTMLPlugInElement)
     HTMLPlugInElement* imp = V8Proxy::DOMWrapperToNode<HTMLPlugInElement>(info.Holder());
     ScriptInstance scriptInstance = imp->getInstance();
     if (!scriptInstance)
-        return deferToInterceptor();
+        return notHandledByInterceptor();
 
     v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
     if (instance.IsEmpty())
-        return deferToInterceptor();
+        return notHandledByInterceptor();
 
     return NPObjectGetNamedProperty(instance, name);
 }
@@ -63,11 +63,11 @@ NAMED_PROPERTY_SETTER(HTMLPlugInElement)
     HTMLPlugInElement* imp = V8Proxy::DOMWrapperToNode<HTMLPlugInElement>(info.Holder());
     ScriptInstance scriptInstance = imp->getInstance();
     if (!scriptInstance)
-        return deferToInterceptor();
+        return notHandledByInterceptor();
 
     v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
     if (instance.IsEmpty())
-        return deferToInterceptor();
+        return notHandledByInterceptor();
 
     return NPObjectSetNamedProperty(instance, name, value);
 }
@@ -84,11 +84,11 @@ INDEXED_PROPERTY_GETTER(HTMLPlugInElement)
     HTMLPlugInElement* imp = V8Proxy::DOMWrapperToNode<HTMLPlugInElement>(info.Holder());
     ScriptInstance scriptInstance = imp->getInstance();
     if (!scriptInstance)
-        return deferToInterceptor();
+        return notHandledByInterceptor();
 
     v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
     if (instance.IsEmpty())
-        return deferToInterceptor();
+        return notHandledByInterceptor();
 
     return NPObjectGetIndexedProperty(instance, index);
 }
@@ -99,11 +99,11 @@ INDEXED_PROPERTY_SETTER(HTMLPlugInElement)
     HTMLPlugInElement* imp = V8Proxy::DOMWrapperToNode<HTMLPlugInElement>(info.Holder());
     ScriptInstance scriptInstance = imp->getInstance();
     if (!scriptInstance)
-        return deferToInterceptor();
+        return notHandledByInterceptor();
 
     v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
     if (instance.IsEmpty())
-        return deferToInterceptor();
+        return notHandledByInterceptor();
 
     return NPObjectSetIndexedProperty(instance, index, value);
 }