2011-03-30 Andrey Kosyakov <caseq@chromium.org>
authorcaseq@chromium.org <caseq@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 30 Mar 2011 16:02:35 +0000 (16:02 +0000)
committercaseq@chromium.org <caseq@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 30 Mar 2011 16:02:35 +0000 (16:02 +0000)
        Reviewed by Pavel Feldman.

        Web Inspector: audit run never completes, fails in DOMAgent.js
        https://bugs.webkit.org/show_bug.cgi?id=57349

        - assure document is present before calling DOMAgent.querySelectAll()

        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):

2011-03-30  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: audit run never completes, fails in DOMAgent.js
        https://bugs.webkit.org/show_bug.cgi?id=57349

        * inspector/audits/audits-panel-functional.html: do not select Elements panel before running Audits, this hides bug 57349

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/inspector/audits/audits-panel-functional.html
Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/AuditRules.js

index 1ee4d28..238a041 100644 (file)
@@ -1,3 +1,12 @@
+2011-03-30  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: audit run never completes, fails in DOMAgent.js
+        https://bugs.webkit.org/show_bug.cgi?id=57349
+
+        * inspector/audits/audits-panel-functional.html: do not select Elements panel before running Audits, this hides bug 57349
+
 2011-03-30  Jessie Berlin  <jberlin@apple.com>
 
         [Leopard Intel Release Tests] editing/spelling/grammar.html failing since introduction in
index 7c9f2eb..50dec2f 100644 (file)
@@ -16,8 +16,6 @@
 <script>
 var test = function()
 {
-    WebInspector.showPanel("elements");
-
     InspectorTest.reloadPage(step1);
 
     function step1()
index 8eb2204..3ecf7a0 100644 (file)
@@ -1,3 +1,15 @@
+2011-03-30  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: audit run never completes, fails in DOMAgent.js
+        https://bugs.webkit.org/show_bug.cgi?id=57349
+
+        - assure document is present before calling DOMAgent.querySelectAll()
+
+        * inspector/front-end/AuditRules.js:
+        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
+
 2011-03-30  Yury Semikhatsky  <yurys@chromium.org>
 
         Unreviewed. Build fix.
index f3e28d8..ddab1df 100644 (file)
@@ -729,7 +729,12 @@ WebInspector.AuditRules.ImageDimensionsRule.prototype = {
                 WebInspector.cssModel.getStylesAsync(nodeIds[i], imageStylesReady.bind(this, nodeIds[i], i === nodeIds.length - 1));
         }
 
-        DOMAgent.querySelectorAll(0, "img[src]", true, getStyles);
+        function getImages()
+        {
+            DOMAgent.querySelectorAll(0, "img[src]", true, getStyles);
+        }
+
+        WebInspector.domAgent.requestDocument(getImages);
     }
 }