ExtendableMessageEvent constructor fails to initialize the 'source' attribute
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Dec 2017 00:28:44 +0000 (00:28 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Dec 2017 00:28:44 +0000 (00:28 +0000)
https://bugs.webkit.org/show_bug.cgi?id=180954

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

* web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event-constructor.https-expected.txt:

Source/WebCore:

No new tests, rebaselined existing test.

* workers/service/ExtendableMessageEvent.cpp:
(WebCore::ExtendableMessageEvent::ExtendableMessageEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event-constructor.https-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/workers/service/ExtendableMessageEvent.cpp

index 452e848..cc2bbde 100644 (file)
@@ -1,3 +1,14 @@
+2017-12-18  Chris Dumez  <cdumez@apple.com>
+
+        ExtendableMessageEvent constructor fails to initialize the 'source' attribute
+        https://bugs.webkit.org/show_bug.cgi?id=180954
+
+        Reviewed by Youenn Fablet.
+
+        Rebaseline WPT test now that more checks are passing.
+
+        * web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event-constructor.https-expected.txt:
+
 2017-12-18  Youenn Fablet  <youenn@apple.com>
 
         SameOrigin and CORS fetch should fail on opaque responses served from ServiceWorker
index a0f0d43..4f05e8b 100644 (file)
@@ -6,8 +6,8 @@ PASS `cancelable` is specified
 PASS `data` is specified 
 PASS `origin` is specified 
 PASS `lastEventId` is specified 
-FAIL `source` is specified assert_equals: expected object "[object MessagePort]" but got null
+PASS `source` is specified 
 FAIL `ports` is specified assert_throws: function "function () {
       createEvent({ get ports() { throw { name: 'Error' }; } }); }" threw object "TypeError: Value is not a sequence" ("TypeError") expected object "[object Object]" ("Error")
-FAIL all initial values are specified assert_equals: expected object "[object MessagePort]" but got null
+PASS all initial values are specified 
 
index 4f7ef6c..50f5d91 100644 (file)
@@ -1,3 +1,15 @@
+2017-12-18  Chris Dumez  <cdumez@apple.com>
+
+        ExtendableMessageEvent constructor fails to initialize the 'source' attribute
+        https://bugs.webkit.org/show_bug.cgi?id=180954
+
+        Reviewed by Youenn Fablet.
+
+        No new tests, rebaselined existing test.
+
+        * workers/service/ExtendableMessageEvent.cpp:
+        (WebCore::ExtendableMessageEvent::ExtendableMessageEvent):
+
 2017-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         [Attachment Support] Insert images as inline attachments when pasting and dropping
index 2526738..280ca6a 100644 (file)
@@ -42,6 +42,7 @@ ExtendableMessageEvent::ExtendableMessageEvent(JSC::ExecState& state, const Atom
     , m_data(SerializedScriptValue::create(state, init.data, SerializationErrorMode::NonThrowing))
     , m_origin(init.origin)
     , m_lastEventId(init.lastEventId)
+    , m_source(init.source)
     , m_ports(init.ports)
 {
 }