2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 30 May 2011 07:22:21 +0000 (07:22 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 30 May 2011 07:22:21 +0000 (07:22 +0000)
        Unreviewed, rolling out r87618.
        http://trac.webkit.org/changeset/87618
        https://bugs.webkit.org/show_bug.cgi?id=61720

        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
        abarth|gardener on #webkit).

        * fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Removed.
        * fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87618.
        http://trac.webkit.org/changeset/87618
        https://bugs.webkit.org/show_bug.cgi?id=61720

        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
        abarth|gardener on #webkit).

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt [deleted file]
LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients.html [deleted file]
LayoutTests/platform/gtk/Skipped
LayoutTests/platform/mac/Skipped
LayoutTests/platform/qt/Skipped
LayoutTests/platform/win/Skipped
Source/WebCore/ChangeLog
Source/WebCore/html/HTMLLinkElement.cpp

index d2e8f5c..fe1b154 100644 (file)
@@ -1,3 +1,19 @@
+2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r87618.
+        http://trac.webkit.org/changeset/87618
+        https://bugs.webkit.org/show_bug.cgi?id=61720
+
+        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
+        abarth|gardener on #webkit).
+
+        * fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Removed.
+        * fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Removed.
+        * platform/gtk/Skipped:
+        * platform/mac/Skipped:
+        * platform/qt/Skipped:
+        * platform/win/Skipped:
+
 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
 
         Reviewed by Kent Tamura.
diff --git a/LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt b/LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt
deleted file mode 100644 (file)
index 47cdd03..0000000
+++ /dev/null
@@ -1,2 +0,0 @@
-PASS we didn't crash.
-This test makes sure that a single prefetch element is not a client of multiple cachedresources at the same time; by repeatedly changing an existing link element, we will induce a double-notify bug if that element is not releasing its cachedresource on update.
diff --git a/LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients.html b/LayoutTests/fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
deleted file mode 100644 (file)
index b15832c..0000000
+++ /dev/null
@@ -1,38 +0,0 @@
-<html>
-<body onload="many_link_updates(50);setTimeout('done();',0)">
-<div id="console"></div>
-<script src="../../js/resources/js-test-pre.js"></script>
-<script>
-
-function addLink(url, rel) {
-    var link = document.getElementById(rel) ||
-               document.createElement('link');
-    link.id = rel;
-    link.rel = rel;
-    link.href = url;
-    document.body.appendChild(link);
-}
-
-function many_link_updates(iter) {
-    for(var i=0;i<iter;++i) {
-        addLink("many_link_updates_" + i + ".html", "prefetch");
-    }
-}
-
-function done() {
-    testPassed("we didn't crash.");
-    if (window.layoutTestController) {
-        layoutTestController.notifyDone();
-    }
-}
-
-if (window.layoutTestController) {
-    layoutTestController.waitUntilDone(); 
-    layoutTestController.dumpAsText();
-}
-</script>
-<p>This test makes sure that a single prefetch element is not a client of multiple cachedresources at the same time; by 
-repeatedly changing an existing link element, we will induce a double-notify bug if that element is not releasing its
-cachedresource on update.</p>
-</body>
-</html>
index 51c65c2..dbcc33c 100644 (file)
@@ -972,10 +972,9 @@ fast/forms/slider-zoomed.html
 # Link prefetch is disabled by default
 fast/dom/HTMLLinkElement/link-and-subresource-test.html
 fast/dom/HTMLLinkElement/prefetch.html
-fast/dom/HTMLLinkElement/prefetch-beforeload.html
 fast/dom/HTMLLinkElement/prefetch-onerror.html
 fast/dom/HTMLLinkElement/prefetch-onload.html
-fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
+fast/dom/HTMLLinkElement/prefetch-beforeload.html
 fast/dom/HTMLLinkElement/prerender.html
 fast/dom/HTMLLinkElement/subresource.html
 
index 0e7dfc8..c306325 100644 (file)
@@ -182,7 +182,6 @@ fast/dom/HTMLLinkElement/prefetch.html
 fast/dom/HTMLLinkElement/prefetch-beforeload.html
 fast/dom/HTMLLinkElement/prefetch-onerror.html
 fast/dom/HTMLLinkElement/prefetch-onload.html
-fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
 fast/dom/HTMLLinkElement/prerender.html
 fast/dom/HTMLLinkElement/subresource.html
 http/tests/misc/link-rel-prefetch-and-subresource.html
index 31fe4b8..9ba9943 100644 (file)
@@ -1948,7 +1948,6 @@ fast/dom/HTMLLinkElement/prefetch.html
 fast/dom/HTMLLinkElement/prefetch-beforeload.html
 fast/dom/HTMLLinkElement/prefetch-onerror.html
 fast/dom/HTMLLinkElement/prefetch-onload.html
-fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
 fast/dom/HTMLLinkElement/prerender.html
 fast/dom/HTMLLinkElement/subresource.html
 http/tests/misc/link-rel-prefetch-and-subresource.html
index 38b2749..e7b283c 100644 (file)
@@ -1007,7 +1007,6 @@ fast/dom/HTMLLinkElement/prefetch.html
 fast/dom/HTMLLinkElement/prefetch-beforeload.html
 fast/dom/HTMLLinkElement/prefetch-onerror.html
 fast/dom/HTMLLinkElement/prefetch-onload.html
-fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
 http/tests/misc/link-rel-prefetch-and-subresource.html
 fast/dom/HTMLLinkElement/prerender.html
 fast/dom/HTMLLinkElement/subresource.html
index aa91e47..9e8dd09 100644 (file)
@@ -1,3 +1,15 @@
+2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r87618.
+        http://trac.webkit.org/changeset/87618
+        https://bugs.webkit.org/show_bug.cgi?id=61720
+
+        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
+        abarth|gardener on #webkit).
+
+        * html/HTMLLinkElement.cpp:
+        (WebCore::HTMLLinkElement::process):
+
 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
 
         Reviewed by Kent Tamura.
index 9c25d8c..f93d1c0 100644 (file)
@@ -266,11 +266,6 @@ void HTMLLinkElement::process()
             type = CachedResource::LinkPrerender;
 
         ResourceRequest linkRequest(document()->completeURL(m_url));
-        
-        if (m_cachedLinkResource) {
-            m_cachedLinkResource->removeClient(this);
-            m_cachedLinkResource = 0;
-        }
         m_cachedLinkResource = document()->cachedResourceLoader()->requestLinkResource(type, linkRequest, priority);
         if (m_cachedLinkResource)
             m_cachedLinkResource->addClient(this);