Use scores everywhere in JetStream2's UI
authorsbarati@apple.com <sbarati@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 19 Jan 2019 03:05:09 +0000 (03:05 +0000)
committersbarati@apple.com <sbarati@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 19 Jan 2019 03:05:09 +0000 (03:05 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193593

Reviewed by Keith Miller.

* JetStream2/JetStreamDriver.js:
(DefaultBenchmark.prototype.processResults):
(DefaultBenchmark.prototype.get score):
(DefaultBenchmark.scoreDescription):
(WSLBenchmark.prototype.processResults):
(WSLBenchmark.prototype.get score):
(WSLBenchmark.scoreDescription):
(WasmBenchmark.prototype.processResults):
(WasmBenchmark.prototype.get score):
(WasmBenchmark.scoreDescription):
* JetStream2/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

PerformanceTests/ChangeLog
PerformanceTests/JetStream2/JetStreamDriver.js
PerformanceTests/JetStream2/index.html

index 299109e..c045c1e 100644 (file)
@@ -1,3 +1,22 @@
+2019-01-18  Saam Barati  <sbarati@apple.com>
+
+        Use scores everywhere in JetStream2's UI
+        https://bugs.webkit.org/show_bug.cgi?id=193593
+
+        Reviewed by Keith Miller.
+
+        * JetStream2/JetStreamDriver.js:
+        (DefaultBenchmark.prototype.processResults):
+        (DefaultBenchmark.prototype.get score):
+        (DefaultBenchmark.scoreDescription):
+        (WSLBenchmark.prototype.processResults):
+        (WSLBenchmark.prototype.get score):
+        (WSLBenchmark.scoreDescription):
+        (WasmBenchmark.prototype.processResults):
+        (WasmBenchmark.prototype.get score):
+        (WasmBenchmark.scoreDescription):
+        * JetStream2/index.html:
+
 2019-01-18  Jer Noble  <jer.noble@apple.com>
 
         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
index 35a7526..98dfd92 100644 (file)
@@ -588,7 +588,7 @@ class DefaultBenchmark extends Benchmark {
         }
         results = copyArray(results);
 
-        this.firstIteration = results[0];
+        this.firstIteration = toScore(results[0]);
 
         results = results.slice(1);
         results.sort((a, b) => a < b ? 1 : -1);
@@ -598,12 +598,12 @@ class DefaultBenchmark extends Benchmark {
         let worstCase = [];
         for (let i = 0; i < this.worstCaseCount; ++i)
             worstCase.push(results[i]);
-        this.worst4 = mean(worstCase);
-        this.average = mean(results);
+        this.worst4 = toScore(mean(worstCase));
+        this.average = toScore(mean(results));
     }
 
     get score() {
-        return toScore(geomean([this.firstIteration, this.worst4, this.average]));
+        return geomean([this.firstIteration, this.worst4, this.average]);
     }
 
     subTimes() {
@@ -615,7 +615,7 @@ class DefaultBenchmark extends Benchmark {
     }
 
     static scoreDescription() {
-        return ["First (ms)", "Worst (ms)", "Average (ms)", "Score"];
+        return ["First", "Worst", "Average", "Score"];
     }
 
     scoreIdentifiers() {
@@ -674,12 +674,12 @@ class WSLBenchmark extends Benchmark {
     }
 
     processResults(results) {
-        this.stdlib = results[0];
-        this.mainRun = results[1];
+        this.stdlib = toScore(results[0]);
+        this.mainRun = toScore(results[1]);
     }
 
     get score() {
-        return toScore(geomean([this.stdlib, this.mainRun]));
+        return geomean([this.stdlib, this.mainRun]);
     }
 
     get runnerCode() {
@@ -710,7 +710,7 @@ class WSLBenchmark extends Benchmark {
     }
 
     static scoreDescription() {
-        return ["Stdlib (ms)", "MainRun (ms)", "Score"];
+        return ["Stdlib", "MainRun", "Score"];
     }
 
     scoreIdentifiers() {
@@ -747,12 +747,12 @@ class WasmBenchmark extends Benchmark {
     }
 
     processResults(results) {
-        this.startupTime = results[0];
-        this.runTime = results[1];
+        this.startupTime = toScore(results[0]);
+        this.runTime = toScore(results[1]);
     }
 
     get score() {
-        return toScore(geomean([this.startupTime, this.runTime]));
+        return geomean([this.startupTime, this.runTime]);
     }
 
     get wasmPath() {
@@ -857,7 +857,7 @@ class WasmBenchmark extends Benchmark {
     }
 
     static scoreDescription() {
-        return ["Startup (ms)", "Runtime (ms)", "Score"];
+        return ["Startup", "Runtime", "Score"];
     }
 
     get startupID() {
index a3c8666..b351345 100644 (file)
@@ -52,7 +52,7 @@
 <!-- <a href="index.html"><img id="logo" src="JetStream-Logo.png" alt="JetStream"></a> -->
 
     <h1>JetStream 2</h1>
-    <p class="summary">JetStream is a JavaScript benchmark suite focused on the most advanced web applications. For more information, read the <a href="in-depth.html">in-depth analysis</a>. Higher scores are better.</p>
+    <p class="summary">JetStream is a JavaScript benchmark suite focused on the most advanced web applications. For more information, read the <a href="in-depth.html">in-depth analysis</a>. Higher scores are better.</p>
     <p class="summary" id="mode-description"></p>
 
     <div id="result-summary"></div>