[GTK] After upgrading glib and glib-networking, resources with zero bytes are always...
authorcsaavedra@igalia.com <csaavedra@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 May 2017 12:58:44 +0000 (12:58 +0000)
committercsaavedra@igalia.com <csaavedra@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 May 2017 12:58:44 +0000 (12:58 +0000)
https://bugs.webkit.org/show_bug.cgi?id=171058

Reviewed by Carlos Garcia Campos.

GLib-based ports have issues detecting the mimetypes of empty
files, as they are all considered to be text/plain by
glib. Replace these resources with a minimal valid file for its
type (that is, 1x1 PNG files and 1 whitespace for text files).

* fast/preloader/resources/base-image1.png:
* fast/preloader/resources/base-image2.png:
* fast/preloader/resources/base-image3.png:
* fast/preloader/resources/image1.png:
* fast/preloader/resources/link1.css:
* fast/preloader/resources/noscript-image1.png:
* fast/preloader/resources/noscript-image2.png:
* fast/preloader/resources/script1.js:
* fast/preloader/resources/style1.css:
* tables/mozilla/core/col_widths_fix_autoFixPer.html:

* platform/gtk/TestExpectations: Unskip the now passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/preloader/resources/base-image1.png
LayoutTests/fast/preloader/resources/base-image2.png
LayoutTests/fast/preloader/resources/base-image3.png
LayoutTests/fast/preloader/resources/image1.png
LayoutTests/fast/preloader/resources/link1.css
LayoutTests/fast/preloader/resources/noscript-image1.png
LayoutTests/fast/preloader/resources/noscript-image2.png
LayoutTests/fast/preloader/resources/script1.js
LayoutTests/fast/preloader/resources/style1.css
LayoutTests/platform/gtk/TestExpectations
LayoutTests/tables/mozilla/core/col_widths_fix_autoFixPer.html

index a382c57..0ec14a6 100644 (file)
@@ -1,3 +1,28 @@
+2017-05-12  Claudio Saavedra  <csaavedra@igalia.com>
+
+        [GTK] After upgrading glib and glib-networking, resources with zero bytes are always identified as text/plain
+        https://bugs.webkit.org/show_bug.cgi?id=171058
+
+        Reviewed by Carlos Garcia Campos.
+
+        GLib-based ports have issues detecting the mimetypes of empty
+        files, as they are all considered to be text/plain by
+        glib. Replace these resources with a minimal valid file for its
+        type (that is, 1x1 PNG files and 1 whitespace for text files).
+
+        * fast/preloader/resources/base-image1.png:
+        * fast/preloader/resources/base-image2.png:
+        * fast/preloader/resources/base-image3.png:
+        * fast/preloader/resources/image1.png:
+        * fast/preloader/resources/link1.css:
+        * fast/preloader/resources/noscript-image1.png:
+        * fast/preloader/resources/noscript-image2.png:
+        * fast/preloader/resources/script1.js:
+        * fast/preloader/resources/style1.css:
+        * tables/mozilla/core/col_widths_fix_autoFixPer.html:
+
+        * platform/gtk/TestExpectations: Unskip the now passing tests.
+
 2017-05-12  Antti Koivisto  <antti@apple.com>
 
         Updating class name of a shadow host does not update the style applied by descendants of :host()
index e69de29..76a749b 100644 (file)
Binary files a/LayoutTests/fast/preloader/resources/base-image1.png and b/LayoutTests/fast/preloader/resources/base-image1.png differ
index e69de29..76a749b 100644 (file)
Binary files a/LayoutTests/fast/preloader/resources/base-image2.png and b/LayoutTests/fast/preloader/resources/base-image2.png differ
index e69de29..76a749b 100644 (file)
Binary files a/LayoutTests/fast/preloader/resources/base-image3.png and b/LayoutTests/fast/preloader/resources/base-image3.png differ
index e69de29..76a749b 100644 (file)
Binary files a/LayoutTests/fast/preloader/resources/image1.png and b/LayoutTests/fast/preloader/resources/image1.png differ
index e69de29..76a749b 100644 (file)
Binary files a/LayoutTests/fast/preloader/resources/noscript-image1.png and b/LayoutTests/fast/preloader/resources/noscript-image1.png differ
index e69de29..76a749b 100644 (file)
Binary files a/LayoutTests/fast/preloader/resources/noscript-image2.png and b/LayoutTests/fast/preloader/resources/noscript-image2.png differ
index 58b4186..9e105c0 100644 (file)
@@ -1366,21 +1366,6 @@ fast/animation/request-animation-frame-throttling-lowPowerMode.html [ Failure ]
 # WebGPU is not enabled on GTK+.
 fast/canvas/webgpu [ Skip ]
 
-# Failure to identify mime-type of empty (zero byte) resources.
-webkit.org/b/171058 fast/preloader/document-write-noscript.html [ Failure ]
-webkit.org/b/171058 fast/preloader/document-write.html [ Failure ]
-webkit.org/b/171058 fast/preloader/first-base-tag-scanned-wins.html [ Failure ]
-webkit.org/b/171058 fast/preloader/first-base-tag-wins.html [ Failure ]
-webkit.org/b/171058 fast/preloader/image-srcset.html [ Failure ]
-webkit.org/b/171058 fast/preloader/image.html [ Failure ]
-webkit.org/b/171058 fast/preloader/input.html [ Failure ]
-webkit.org/b/171058 fast/preloader/link.html [ Failure ]
-webkit.org/b/171058 fast/preloader/noscript.html [ Failure ]
-webkit.org/b/171058 fast/preloader/script.html [ Failure ]
-webkit.org/b/171058 fast/preloader/style.html [ Failure ]
-webkit.org/b/171058 fast/preloader/understands-base-tag.html [ Failure ]
-webkit.org/b/171058 tables/mozilla/core/col_widths_fix_autoFixPer.html [ Failure ]
-
 #////////////////////////////////////////////////////////////////////////////////////////
 # End of Expected failures
 #////////////////////////////////////////////////////////////////////////////////////////