REGRESSION [ PHP ][ iOS ]: Two http/tests/cookies/same-site/set-first-party-* Tests...
authordbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Nov 2019 17:37:48 +0000 (17:37 +0000)
committerdbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Nov 2019 17:37:48 +0000 (17:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=203567
<rdar://problem/56708500>

Reviewed by Youenn Fablet.

A callable must be passed by string in PHP. Any other way seems to be non-standard and your
mileage may vary.

* http/tests/cookies/resources/cookie-utilities.php:
* http/tests/cookies/resources/cookie-utility.php:
* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/http/tests/cookies/resources/cookie-utilities.php
LayoutTests/http/tests/cookies/resources/cookie-utility.php
LayoutTests/platform/ios-wk2/TestExpectations

index 40f7275..494e7db 100644 (file)
@@ -1,5 +1,20 @@
 2019-11-06  Daniel Bates  <dabates@apple.com>
 
+        REGRESSION [ PHP ][ iOS ]: Two http/tests/cookies/same-site/set-first-party-* Tests are Failing
+        https://bugs.webkit.org/show_bug.cgi?id=203567
+        <rdar://problem/56708500>
+
+        Reviewed by Youenn Fablet.
+
+        A callable must be passed by string in PHP. Any other way seems to be non-standard and your
+        mileage may vary.
+
+        * http/tests/cookies/resources/cookie-utilities.php:
+        * http/tests/cookies/resources/cookie-utility.php:
+        * platform/ios-wk2/TestExpectations:
+
+2019-11-06  Daniel Bates  <dabates@apple.com>
+
         http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html is a Flakey Failure
         https://bugs.webkit.org/show_bug.cgi?id=198924
         <rdar://problem/51811010>
index 4a2595e..f92c813 100644 (file)
@@ -48,6 +48,6 @@ function _deleteCookieCallback($value, $name)
 
 function resetCookiesForCurrentOrigin()
 {
-    array_walk($_COOKIE, _deleteCookieCallback);
+    array_walk($_COOKIE, '_deleteCookieCallback');
 }
 ?>
index ed9a633..2270958 100644 (file)
@@ -41,7 +41,7 @@ function echoCookie($value, $name)
 function echoAllCookies()
 {
     echo "Cookies are:\n";
-    array_walk($_COOKIE, echoCookie);    
+    array_walk($_COOKIE, 'echoCookie');
 }
 
 ?>
index 29aa2fd..5522f5c 100644 (file)
@@ -1364,10 +1364,5 @@ webkit.org/b/203577 fast/scrolling/ios/touch-scroll-visibility-hidden.html [ Pas
 webkit.org/b/203572 media/remoteplayback-prompt.html [ Skip ]
 webkit.org/b/203572 media/remoteplayback-target-availability.html [ Skip ]
 
-# <rdar://problem/56708500> REGRESSION [ PHP ][ iOS ]: Two http/tests/cookies/same-site/set-first-party-* Tests are Failing (203567)
-webkit.org/b/203567 http/tests/cookies/same-site/set-first-party-cross-site-cookies.php [ Failure ]
-webkit.org/b/203567 http/tests/cookies/same-site/set-first-party-same-site-cookies.php [ Failure ]
-
 # <rdar://problem/56761171> [ iOS ] Layout Test fast/css-custom-paint/simple-hidpi.html is a Flaky Failure (203637)
 webkit.org/b/203637 fast/css-custom-paint/simple-hidpi.html [ Pass ImageOnlyFailure ]
-