[WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDele...
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Oct 2013 12:23:15 +0000 (12:23 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Oct 2013 12:23:15 +0000 (12:23 +0000)
https://bugs.webkit.org/show_bug.cgi?id=122276

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/css/.

* css/CSSHostRule.idl:
* css/CSSMediaRule.idl:
* css/CSSPrimitiveValue.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleSheet.idl:
* css/CSSSupportsRule.idl:
* css/CSSValueList.idl:
* css/DOMWindowCSS.idl:
* css/FontLoader.idl:
* css/MediaList.idl:
* css/MediaQueryList.idl:
* css/MediaQueryListListener.idl:
* css/StyleMedia.idl:
* css/StyleSheet.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSMatrix.idl:
* css/WebKitCSSTransformValue.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

21 files changed:
Source/WebCore/ChangeLog
Source/WebCore/css/CSSHostRule.idl
Source/WebCore/css/CSSMediaRule.idl
Source/WebCore/css/CSSPrimitiveValue.idl
Source/WebCore/css/CSSRuleList.idl
Source/WebCore/css/CSSStyleDeclaration.idl
Source/WebCore/css/CSSStyleSheet.idl
Source/WebCore/css/CSSSupportsRule.idl
Source/WebCore/css/CSSValueList.idl
Source/WebCore/css/DOMWindowCSS.idl
Source/WebCore/css/FontLoader.idl
Source/WebCore/css/MediaList.idl
Source/WebCore/css/MediaQueryList.idl
Source/WebCore/css/MediaQueryListListener.idl
Source/WebCore/css/StyleMedia.idl
Source/WebCore/css/StyleSheet.idl
Source/WebCore/css/StyleSheetList.idl
Source/WebCore/css/WebKitCSSFilterValue.idl
Source/WebCore/css/WebKitCSSKeyframesRule.idl
Source/WebCore/css/WebKitCSSMatrix.idl
Source/WebCore/css/WebKitCSSTransformValue.idl

index 57cbf88..279e38b 100644 (file)
@@ -1,5 +1,42 @@
 2013-10-04  Zan Dobersek  <zdobersek@igalia.com>
 
+        [WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDeletable attribute
+        https://bugs.webkit.org/show_bug.cgi?id=122276
+
+        Reviewed by Darin Adler.
+
+        Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
+        interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
+        doesn't have any effect, but will keep the operations not configurable after the generator is modified
+        to preserve the original behavior. The attribute will be removed from each interface after checking
+        conformity with other browsers (in terms of configurability of operations of that interface) and the
+        WebKit's existing test suites.
+
+        This patch covers IDL interfaces under Source/WebCore/css/.
+
+        * css/CSSHostRule.idl:
+        * css/CSSMediaRule.idl:
+        * css/CSSPrimitiveValue.idl:
+        * css/CSSRuleList.idl:
+        * css/CSSStyleDeclaration.idl:
+        * css/CSSStyleSheet.idl:
+        * css/CSSSupportsRule.idl:
+        * css/CSSValueList.idl:
+        * css/DOMWindowCSS.idl:
+        * css/FontLoader.idl:
+        * css/MediaList.idl:
+        * css/MediaQueryList.idl:
+        * css/MediaQueryListListener.idl:
+        * css/StyleMedia.idl:
+        * css/StyleSheet.idl:
+        * css/StyleSheetList.idl:
+        * css/WebKitCSSFilterValue.idl:
+        * css/WebKitCSSKeyframesRule.idl:
+        * css/WebKitCSSMatrix.idl:
+        * css/WebKitCSSTransformValue.idl:
+
+2013-10-04  Zan Dobersek  <zdobersek@igalia.com>
+
         [WebIDL] Annotate IDL interfaces under Source/WebCore/loader/appcache/ with the OperationsNotDeletable attribute
         https://bugs.webkit.org/show_bug.cgi?id=122274
 
index edac345..0ae1e2c 100644 (file)
@@ -21,6 +21,7 @@
 // Introduced in Shadow DOM spec:
 [
     Conditional=SHADOW_DOM,
+    OperationsNotDeletable
 ] interface CSSHostRule : CSSRule {
     readonly attribute CSSRuleList cssRules;
     
index 38aeef2..7f1af91 100644 (file)
@@ -19,7 +19,9 @@
  */
 
 // Introduced in DOM Level 2:
-interface CSSMediaRule : CSSRule {
+[
+    OperationsNotDeletable
+] interface CSSMediaRule : CSSRule {
     readonly attribute MediaList media;
     readonly attribute CSSRuleList cssRules;
     
index 7b3c909..31d35f4 100644 (file)
@@ -18,7 +18,8 @@
  */
 
 [
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface CSSPrimitiveValue : CSSValue {
 
     // UnitTypes
index e936a86..5c6ff75 100644 (file)
@@ -26,7 +26,8 @@
 // Introduced in DOM Level 2:
 [
     CustomIsReachable,
-    SkipVTableValidation
+    SkipVTableValidation,
+    OperationsNotDeletable
 ] interface CSSRuleList {
     readonly attribute unsigned long    length;
     getter CSSRule item([Default=Undefined] optional unsigned long index);
index 14b6466..1f46fae 100644 (file)
@@ -26,7 +26,8 @@
     JSCustomGetOwnPropertySlotAndDescriptor,
     CustomNamedSetter,
     CustomEnumerateProperty,
-    SkipVTableValidation
+    SkipVTableValidation,
+    OperationsNotDeletable
 ] interface CSSStyleDeclaration {
     [TreatReturnedNullStringAs=Null, TreatNullAs=NullString, SetterRaisesException] attribute DOMString cssText;
 
index d02132f..3d31d5f 100644 (file)
@@ -19,7 +19,9 @@
  */
 
 // Introduced in DOM Level 2:
-interface CSSStyleSheet : StyleSheet {
+[
+    OperationsNotDeletable
+] interface CSSStyleSheet : StyleSheet {
     readonly attribute CSSRule          ownerRule;
     readonly attribute CSSRuleList      cssRules;
 
index 9afff8d..83ff037 100644 (file)
@@ -28,7 +28,8 @@
 
 [
     NoInterfaceObject,
-    Conditional=CSS3_CONDITIONAL_RULES
+    Conditional=CSS3_CONDITIONAL_RULES,
+    OperationsNotDeletable
 ] interface CSSSupportsRule : CSSRule {
     readonly attribute CSSRuleList cssRules;
     readonly attribute DOMString conditionText;
index ca51d6c..44a547f 100644 (file)
@@ -25,7 +25,8 @@
 
 // Introduced in DOM Level 2:
 [
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface CSSValueList : CSSValue {
     readonly attribute unsigned long    length;
     getter CSSValue           item([Default=Undefined] optional unsigned long index);
index a79d86c..eb3584b 100644 (file)
@@ -30,7 +30,8 @@
 [
     NoInterfaceObject,
     InterfaceName=CSS,
-    Conditional=CSS3_CONDITIONAL_RULES
+    Conditional=CSS3_CONDITIONAL_RULES,
+    OperationsNotDeletable
 ] interface DOMWindowCSS {
 
     boolean supports(DOMString property, DOMString value);
index a8190b8..8beb6c2 100644 (file)
@@ -34,6 +34,7 @@
     ActiveDOMObject,
     EventTarget,
     GenerateIsReachable=ImplDocument,
+    OperationsNotDeletable
 ] interface FontLoader {
 
     attribute EventListener onloading;
index 34f8275..b50c707 100644 (file)
@@ -27,7 +27,8 @@
 [
     JSCustomHeader,
     GenerateIsReachable,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface MediaList {
 
     [TreatNullAs=NullString, TreatReturnedNullStringAs=Null, SetterRaisesException] attribute DOMString mediaText;
index b00b705..34c8bd3 100644 (file)
@@ -18,7 +18,8 @@
  */
 [
     NoInterfaceObject,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface MediaQueryList {
     readonly attribute DOMString media;
     readonly attribute boolean matches;
index 5c320ff..483846d 100644 (file)
@@ -18,7 +18,8 @@
  */
 
 [
-    CallbackNeedsOperatorEqual
+    CallbackNeedsOperatorEqual,
+    OperationsNotDeletable
 ] callback interface MediaQueryListListener {
     boolean queryChanged([Default=Undefined] optional MediaQueryList list);
 };
index c100634..9983392 100644 (file)
@@ -26,7 +26,8 @@
 
 [
     NoInterfaceObject,
-    GenerateIsReachable=ImplFrame
+    GenerateIsReachable=ImplFrame,
+    OperationsNotDeletable
 ] interface StyleMedia {
     readonly attribute DOMString type;
     boolean matchMedium([Default=Undefined] optional DOMString mediaquery);
index e275710..5cd53e8 100644 (file)
@@ -25,6 +25,7 @@
     GenerateIsReachable,
     CustomToJSObject,
     ObjCPolymorphic,
+    OperationsNotDeletable
 ] interface StyleSheet {
     [TreatReturnedNullStringAs=Null] readonly attribute DOMString        type;
              attribute boolean          disabled;
index cc6bf3a..fb8b2ad 100644 (file)
@@ -21,7 +21,8 @@
 // Introduced in DOM Level 2:
 [
     GenerateIsReachable=ImplDocument,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface StyleSheetList {
     readonly attribute unsigned long    length;
     getter StyleSheet         item([Default=Undefined] optional unsigned long index);
index f9346f5..d96586a 100644 (file)
@@ -26,7 +26,8 @@
 [
     Conditional=CSS_FILTERS,
     DoNotCheckConstants,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface WebKitCSSFilterValue : CSSValueList {
 
     // OperationTypes
index 4552a7b..40d02f0 100644 (file)
@@ -27,7 +27,9 @@
  */
 
 // Introduced in DOM Level ?:
-interface WebKitCSSKeyframesRule : CSSRule {
+[
+    OperationsNotDeletable
+] interface WebKitCSSKeyframesRule : CSSRule {
 
     [TreatReturnedNullStringAs=Null, TreatNullAs=NullString] attribute DOMString name;
     readonly attribute CSSRuleList cssRules;
index 9b602a8..b5060be 100644 (file)
@@ -27,6 +27,7 @@
 [
     Constructor([Default=NullString] optional DOMString cssValue),
     ConstructorRaisesException,
+    OperationsNotDeletable
 ] interface WebKitCSSMatrix {
 
     // These attributes are simple aliases for certain elements of the 4x4 matrix
index 516211a..4b8cad1 100644 (file)
@@ -28,7 +28,8 @@
 
 [
     DoNotCheckConstants,
-    ImplementationLacksVTable
+    ImplementationLacksVTable,
+    OperationsNotDeletable
 ] interface WebKitCSSTransformValue : CSSValueList {
 
     // OperationTypes