scrolling/ios/hit-testing-iframe* tests need to hide the tap highlight
authorsimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Feb 2019 17:33:44 +0000 (17:33 +0000)
committersimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Feb 2019 17:33:44 +0000 (17:33 +0000)
https://bugs.webkit.org/show_bug.cgi?id=195099

Reviewed by Frederic Wang.

These tests were failing because the ref test captured the tap highlight, so hide
it with -webkit-tap-highlight-color: transparent;

* fast/scrolling/ios/hit-testing-iframe-001.html:
* fast/scrolling/ios/hit-testing-iframe-002.html:
* fast/scrolling/ios/hit-testing-iframe-003.html:
* fast/scrolling/ios/hit-testing-iframe-004.html:
* fast/scrolling/ios/hit-testing-iframe-005.html:
* fast/scrolling/ios/hit-testing-iframe-006.html:
* fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html:
* platform/ios-wk2/TestExpectations: hit-testing-iframe-006.html passes now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/scrolling/ios/hit-testing-iframe-001.html
LayoutTests/fast/scrolling/ios/hit-testing-iframe-002.html
LayoutTests/fast/scrolling/ios/hit-testing-iframe-003.html
LayoutTests/fast/scrolling/ios/hit-testing-iframe-004.html
LayoutTests/fast/scrolling/ios/hit-testing-iframe-005.html
LayoutTests/fast/scrolling/ios/hit-testing-iframe-006.html
LayoutTests/fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html
LayoutTests/platform/ios-wk2/TestExpectations

index 5cdc1cf..eeba4b3 100644 (file)
@@ -1,3 +1,22 @@
+2019-02-27  Simon Fraser  <simon.fraser@apple.com>
+
+        scrolling/ios/hit-testing-iframe* tests need to hide the tap highlight
+        https://bugs.webkit.org/show_bug.cgi?id=195099
+
+        Reviewed by Frederic Wang.
+
+        These tests were failing because the ref test captured the tap highlight, so hide
+        it with -webkit-tap-highlight-color: transparent;
+
+        * fast/scrolling/ios/hit-testing-iframe-001.html:
+        * fast/scrolling/ios/hit-testing-iframe-002.html:
+        * fast/scrolling/ios/hit-testing-iframe-003.html:
+        * fast/scrolling/ios/hit-testing-iframe-004.html:
+        * fast/scrolling/ios/hit-testing-iframe-005.html:
+        * fast/scrolling/ios/hit-testing-iframe-006.html:
+        * fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html:
+        * platform/ios-wk2/TestExpectations: hit-testing-iframe-006.html passes now.
+
 2019-02-27  Ulrich Pflueger  <up@nanocosmos.de>
 
         [MSE] SourceBuffer sample time increment vs. last frame duration check is broken
index 120c98b..3aab006 100644 (file)
@@ -36,8 +36,8 @@
     <p>This test passes if you see a green rectangle.</p>
     <div style="position: absolute; top: 3em; width: 100px; height: 100px; background: green;">
       <iframe id="clickInContentBox" style="left: 0px; top: 0px;" scrolling="yes" onclick="this.style.background='red'" srcdoc="
-          <body style='margin: 0; width: 200px; height: 200px'>
-              <div style='position: absolute; width: 100px; height: 100px; background: red;'
+          <body style='margin: 0; width: 200px; height: 200px;'>
+              <div style='position: absolute; width: 100px; height: 100px; background: red; -webkit-tap-highlight-color: transparent;'
                    onclick='this.style.background=&quot;green&quot;'></div>
           </body>" onload="runTest()">
       </iframe>
index 0676138..7bb0df0 100644 (file)
@@ -37,7 +37,7 @@
     <div style="position: absolute; top: 3em; width: 100px; height: 100px; background: green;">
       <iframe id="clickInPaddingBoxOutOfContentBox" style="left: 0px; top: 0px; background: red;" onclick="this.style.background='green'" scrolling="yes" srcdoc="
           <body style='margin: 0; width: 200px; height: 200px'>
-              <div style='position: absolute; width: 100px; height: 100px; background: green;'
+              <div style='position: absolute; width: 100px; height: 100px; background: green; -webkit-tap-highlight-color: transparent;'
                    onclick='this.style.background=&quot;red&quot;'></div>
           </body>" onload="runTest()">
       </iframe>
index 63c5b14..ab443ed 100644 (file)
@@ -37,7 +37,7 @@
     <div style="position: absolute; top: 3em; width: 100px; height: 100px; background: green;">
       <iframe id="clickElementAboveFrame" style="left: 0px; top: 0px;" scrolling="yes" onclick="this.style.background='red'" srcdoc="
           <body style='margin: 0; width: 200px; height: 200px; background: green;'>
-              <div style='position: absolute; width: 100px; height: 100px; background: green;'
+              <div style='position: absolute; width: 100px; height: 100px; background: green; -webkit-tap-highlight-color: transparent;'
                    onclick='this.style.background=&quot;red&quot;'></div>
           </body>" onload="runTest()">
       </iframe>
index 90a21c8..ae1ac45 100644 (file)
@@ -37,7 +37,7 @@
     <div style="position: absolute; top: 3em; width: 100px; height: 100px; background: green;">
       <iframe id="clickElementInsideFrame" style="left: 0px; top: 0px;" scrolling="yes" onclick="this.style.background='red'" srcdoc="
           <body style='margin: 0; width: 200px; height: 200px; background: green;'>
-              <div style='position: absolute; left: 10px; top: 10px; width: 50px; height: 50px; background: red;'
+              <div style='position: absolute; left: 10px; top: 10px; width: 50px; height: 50px; background: red; -webkit-tap-highlight-color: transparent;'
                    onclick='this.style.background=&quot;green&quot;'></div>
           </body>" onload="runTest()">
       </iframe>
index d6d7d46..adb2688 100644 (file)
@@ -40,7 +40,7 @@
       <iframe id="clickElementInsideFrameAfterProgrammaticScroll" style="left: 0px; top: 0px;" scrolling="yes" onclick="this.style.background='red'" srcdoc="
           <body style='margin: 0; width: 200px; height: 200px; background: green;'>
              <div style='position: absolute; width: 75px; height: 75px; background: red;'></div>
-              <div style='position: absolute; left: 110px; top: 110px; width: 50px; height: 50px; background: red;'
+              <div style='position: absolute; left: 110px; top: 110px; width: 50px; height: 50px; background: red; -webkit-tap-highlight-color: transparent;'
                    onclick='this.style.background=&quot;green&quot;'></div>
           </body>" onload="runTest()">
       </iframe>
index b87a6fc..76d6258 100644 (file)
@@ -48,7 +48,7 @@
       <iframe id="clickElementInsideFrameAfterUserScroll" style="left: 0px; top: 0px;" scrolling="yes" onclick="this.style.background='red'" srcdoc="
           <body style='margin: 0; width: 200px; height: 200px; background: green;'>
              <div style='position: absolute; width: 75px; height: 75px; background: red;'></div>
-              <div style='position: absolute; left: 0px; top: 150px; width: 50px; height: 50px; background: red;'
+              <div style='position: absolute; left: 0px; top: 150px; width: 50px; height: 50px; background: red; -webkit-tap-highlight-color: transparent;'
                    onclick='this.style.background=&quot;green&quot;'></div>
           </body>" onload="runTest()">
       </iframe>
index b89300c..e5c2f9f 100644 (file)
@@ -57,7 +57,7 @@
     <div style="position: absolute; top: 3em; width: 100px; height: 100px; background: green;">
         <iframe id="programmaticYAndUserXAndHitTesting" style="left: 0px; top: 0px;" scrolling="yes" srcdoc="
             <body style='margin: 0; width: 200px; height: 200px'>
-                <div style='left: 100px; top: 100px; position: absolute; width: 100px; height: 100px; background: red;' onclick='this.style.background=&quot;green&quot;'></div>
+                <div style='left: 100px; top: 100px; position: absolute; width: 100px; height: 100px; background: red; -webkit-tap-highlight-color: transparent;' onclick='this.style.background=&quot;green&quot;'></div>
             </body>" onload="runTest()">
         </iframe>
     </div>
index bfd7a9a..3f923fd 100644 (file)
@@ -1075,7 +1075,6 @@ webkit.org/b/156620 legacy-animation-engine/fast/animation/request-animation-fra
 webkit.org/b/153049 perf/array-binary-search.html [ Pass Failure Timeout ]
 
 fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html [ Pass Failure ]
-webkit.org/b/193997 fast/scrolling/ios/hit-testing-iframe-006.html [ ImageOnlyFailure ]
 
 webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]