Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer,...
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Mar 2014 14:59:03 +0000 (14:59 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Mar 2014 14:59:03 +0000 (14:59 +0000)
https://bugs.webkit.org/show_bug.cgi?id=130310

Reviewed by Darin Adler.

Building the GTK port with Clang through CMake falls into a configuration where
the cstdio header is not indirectly included in InlineTextBox, RenderLayer and
RenderObject source files. fprintf() is required for helper functions that print
out helpful debugging information in debug builds, so the cstdio header should
be included explicitly in that case.

* rendering/InlineTextBox.cpp:
* rendering/RenderLayer.cpp:
* rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@165732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/rendering/InlineTextBox.cpp
Source/WebCore/rendering/RenderLayer.cpp
Source/WebCore/rendering/RenderObject.cpp

index bb59efa..d1c7340 100644 (file)
@@ -1,3 +1,20 @@
+2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
+
+        Explicitly include cstdio header for debug builds in InlineTextBox, RenderLayer, RenderObject
+        https://bugs.webkit.org/show_bug.cgi?id=130310
+
+        Reviewed by Darin Adler.
+
+        Building the GTK port with Clang through CMake falls into a configuration where
+        the cstdio header is not indirectly included in InlineTextBox, RenderLayer and
+        RenderObject source files. fprintf() is required for helper functions that print
+        out helpful debugging information in debug builds, so the cstdio header should
+        be included explicitly in that case.
+
+        * rendering/InlineTextBox.cpp:
+        * rendering/RenderLayer.cpp:
+        * rendering/RenderObject.cpp:
+
 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GTK] Cleanup WebKitDOMObject
index f6cbee6..f9f56f5 100644 (file)
 #include "break_lines.h"
 #include <wtf/text/CString.h>
 
+#ifndef NDEBUG
+#include <cstdio>
+#endif
+
 namespace WebCore {
 
 struct SameSizeAsInlineTextBox : public InlineBox {
index 00e7830..7bc26d6 100644 (file)
 #include "RenderLayerFilterInfo.h"
 #endif
 
+#ifndef NDEBUG
+#include <cstdio>
+#endif
+
 
 #define MIN_INTERSECT_FOR_REVEAL 32
 
index e05c4bb..148e986 100644 (file)
 #include "SelectionRect.h"
 #endif
 
+#ifndef NDEBUG
+#include <cstdio>
+#endif
+
 namespace WebCore {
 
 using namespace HTMLNames;