[Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend...
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 May 2013 08:14:49 +0000 (08:14 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 May 2013 08:14:49 +0000 (08:14 +0000)
https://bugs.webkit.org/show_bug.cgi?id=115636

Reviewed by Ryosuke Niwa.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
while Chromium-specific, can't be removed just yet as there's more code that uses it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestResultServer/static-dashboards/flakiness_dashboard.js

index 1a25e31..01a0770 100644 (file)
@@ -1,3 +1,15 @@
+2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
+
+        [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
+        https://bugs.webkit.org/show_bug.cgi?id=115636
+
+        Reviewed by Ryosuke Niwa.
+
+        * TestResultServer/static-dashboards/flakiness_dashboard.js:
+        (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
+        through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
+        while Chromium-specific, can't be removed just yet as there's more code that uses it.
+
 2013-05-06  Darin Adler  <darin@apple.com>
 
         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
index 06de75f..42ddf7e 100644 (file)
@@ -2440,11 +2440,6 @@ g_fallbacksMap['MAC-LION'] = ['chromium-mac', 'chromium'];
 g_fallbacksMap['LINUX-32'] = ['chromium-linux-x86', 'chromium-linux', 'chromium-win', 'chromium'];
 g_fallbacksMap['LINUX-64'] = ['chromium-linux', 'chromium-win', 'chromium'];
 
-function htmlForFallbackHelp(fallbacks)
-{
-    return '<ol class=fallback-list><li>' + fallbacks.join('</li><li>') + '</li></ol>';
-}
-
 function showLegend()
 {
     var legend = $('legend');
@@ -2460,18 +2455,11 @@ function showLegend()
         html += '<div class=' + expectation + '>' + expectationsMap()[expectation] + '</div>';
 
     html += '<div class=merge>WEBKIT MERGE</div>';
-    if (g_history.isLayoutTestResults()) {
-      html += '</div><br style="clear:both">' +
-          '</div><h3>Test expectatons fallback order.</h3>';
-
-      for (var platform in g_fallbacksMap)
-          html += '<div class=fallback-header>' + platform + '</div>' + htmlForFallbackHelp(g_fallbacksMap[platform]);
-
-      html += '<div>TIMES:</div>' +
+    if (g_history.isLayoutTestResults())
+      html += '</div><br style="clear:both"><div>TIMES:</div>' +
           htmlForSlowTimes(MIN_SECONDS_FOR_SLOW_TEST) +
           '<div>DEBUG TIMES:</div>' +
           htmlForSlowTimes(MIN_SECONDS_FOR_SLOW_TEST_DEBUG);
-    }
 
     legend.innerHTML = html;
 }