Remove unused functions from WebCore and WebKit2
authordbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Nov 2013 23:20:38 +0000 (23:20 +0000)
committerdbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Nov 2013 23:20:38 +0000 (23:20 +0000)
https://bugs.webkit.org/show_bug.cgi?id=124739

Reviewed by Alexey Proskuryakov.

Source/WebCore:

* editing/markup.cpp: Remove unused functions isHTMLBlockElement and
ancestorToRetainStructureAndAppearanceWithNoRenderer.
* rendering/InlineElementBox.cpp: Append newline to the end of the file.

Source/WebKit2:

Remove unused functions autoreleased({WKURLRequestRef, WKURLResponseRef}).

* UIProcess/API/mac/WKBrowsingContextController.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/editing/markup.cpp
Source/WebCore/rendering/InlineElementBox.cpp
Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm

index a9d96a7..c296289 100644 (file)
@@ -1,5 +1,16 @@
 2013-11-21  Daniel Bates  <dabates@apple.com>
 
+        Remove unused functions from WebCore and WebKit2
+        https://bugs.webkit.org/show_bug.cgi?id=124739
+
+        Reviewed by Alexey Proskuryakov.
+
+        * editing/markup.cpp: Remove unused functions isHTMLBlockElement and
+        ancestorToRetainStructureAndAppearanceWithNoRenderer.
+        * rendering/InlineElementBox.cpp: Append newline to the end of the file.
+
+2013-11-21  Daniel Bates  <dabates@apple.com>
+
         Only generate isObservable() when IDL specifies GenerateIsReachable
         https://bugs.webkit.org/show_bug.cgi?id=124729
 
index d2e75c3..60624df 100644 (file)
@@ -430,13 +430,6 @@ Node* StyledMarkupAccumulator::traverseNodesForSerialization(Node* startNode, No
     return lastClosed;
 }
 
-static bool isHTMLBlockElement(const Node* node)
-{
-    return node->hasTagName(tdTag)
-        || node->hasTagName(thTag)
-        || isNonTableCellHTMLBlockElement(node);
-}
-
 static Node* ancestorToRetainStructureAndAppearanceForBlock(Node* commonAncestorBlock)
 {
     if (!commonAncestorBlock)
@@ -461,12 +454,6 @@ static inline Node* ancestorToRetainStructureAndAppearance(Node* commonAncestor)
     return ancestorToRetainStructureAndAppearanceForBlock(enclosingBlock(commonAncestor));
 }
 
-static inline Node* ancestorToRetainStructureAndAppearanceWithNoRenderer(Node* commonAncestor)
-{
-    Node* commonAncestorBlock = enclosingNodeOfType(firstPositionInOrBeforeNode(commonAncestor), isHTMLBlockElement);
-    return ancestorToRetainStructureAndAppearanceForBlock(commonAncestorBlock);
-}
-
 static bool propertyMissingOrEqualToNone(StylePropertySet* style, CSSPropertyID propertyID)
 {
     if (!style)
index 2126128..c5133ad 100644 (file)
@@ -102,4 +102,4 @@ bool InlineElementBox::nodeAtPoint(const HitTestRequest& request, HitTestResult&
     return renderer().hitTest(request, result, locationInContainer, childPoint);
 }
 
-}
\ No newline at end of file
+}
index 5babcdc..390fda5 100644 (file)
@@ -1,3 +1,14 @@
+2013-11-21  Daniel Bates  <dabates@apple.com>
+
+        Remove unused functions from WebCore and WebKit2
+        https://bugs.webkit.org/show_bug.cgi?id=124739
+
+        Reviewed by Alexey Proskuryakov.
+
+        Remove unused functions autoreleased({WKURLRequestRef, WKURLResponseRef}).
+
+        * UIProcess/API/mac/WKBrowsingContextController.mm:
+
 2013-11-21  Csaba Osztrogon√°c  <ossy@webkit.org>
 
         Rename PlatformCertificateInfo to CertificateInfo
index bf99ea3..41605b7 100644 (file)
@@ -64,16 +64,6 @@ static inline NSURL *autoreleased(WKURLRef url)
     return url ? CFBridgingRelease(WKURLCopyCFURL(kCFAllocatorDefault, adoptWK(url).get())) : nil;
 }
 
-static inline NSURLRequest *autoreleased(WKURLRequestRef urlRequest)
-{
-    return urlRequest ? CFBridgingRelease(WKURLRequestCopyNSURLRequest(adoptWK(urlRequest).get())) : nil;
-}
-
-static inline NSURLResponse *autoreleased(WKURLResponseRef urlResponse)
-{
-    return urlResponse ? CFBridgingRelease(WKURLResponseCopyNSURLResponse(adoptWK(urlResponse).get())) : nil;
-}
-
 NSString * const WKActionIsMainFrameKey = @"WKActionIsMainFrameKey";
 NSString * const WKActionNavigationTypeKey = @"WKActionNavigationTypeKey";
 NSString * const WKActionMouseButtonKey = @"WKActionMouseButtonKey";