ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 30 Sep 2013 21:56:02 +0000 (21:56 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 30 Sep 2013 21:56:02 +0000 (21:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=122032

Patch by Drew Yao <ayao@apple.com> on 2013-09-30
Reviewed by Andreas Kling.

Convert assertion to ASSERT_WITH_SECURITY_IMPLICATION to help catch use after free bugs.

No new tests needed.

* rendering/InlineBox.h:
(WebCore::InlineBox::parent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/rendering/InlineBox.h

index 85551be..fe35697 100644 (file)
@@ -1,3 +1,17 @@
+2013-09-30  Drew Yao  <ayao@apple.com>
+
+        ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
+        https://bugs.webkit.org/show_bug.cgi?id=122032
+
+        Reviewed by Andreas Kling.
+
+        Convert assertion to ASSERT_WITH_SECURITY_IMPLICATION to help catch use after free bugs.
+
+        No new tests needed.
+
+        * rendering/InlineBox.h:
+        (WebCore::InlineBox::parent):
+
 2013-09-30  Yongjun Zhang  <yongjun_zhang@apple.com>
 
         Don't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw data.
index f395cfb..63fc68b 100644 (file)
@@ -185,7 +185,7 @@ public:
 
     InlineFlowBox* parent() const
     {
-        ASSERT(!m_hasBadParent);
+        ASSERT_WITH_SECURITY_IMPLICATION(!m_hasBadParent);
         return m_parent;
     }
     void setParent(InlineFlowBox* par) { m_parent = par; }