Regression(r248832): Unable to quicklook HTML files in Mail
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Sep 2019 15:23:50 +0000 (15:23 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Sep 2019 15:23:50 +0000 (15:23 +0000)
https://bugs.webkit.org/show_bug.cgi?id=202012
<rdar://problem/55285295>

Reviewed by Per Arne Vollan.

Follow-up to fix bug in r250110. Now that loadFile() calls
maybeInitializeSandboxExtensionHandle(), it no longer needs to
call assumeReadAccessToBaseURL(). This is because maybeInitializeSandboxExtensionHandle()
already take care of it.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebPageProxy.cpp

index 1f47d5d..66d2cf6 100644 (file)
@@ -1,3 +1,19 @@
+2019-09-20  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r248832): Unable to quicklook HTML files in Mail
+        https://bugs.webkit.org/show_bug.cgi?id=202012
+        <rdar://problem/55285295>
+
+        Reviewed by Per Arne Vollan.
+
+        Follow-up to fix bug in r250110. Now that loadFile() calls
+        maybeInitializeSandboxExtensionHandle(), it no longer needs to
+        call assumeReadAccessToBaseURL(). This is because maybeInitializeSandboxExtensionHandle()
+        already take care of it.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::loadFile):
+
 2019-09-20  Joonghun Park  <pjh0718@gmail.com>
 
         Unreviewed. Remove duplicated HashMap iteration since r248734.
index b0943bf..40c434a 100644 (file)
@@ -1236,7 +1236,6 @@ RefPtr<API::Navigation> WebPageProxy::loadFile(const String& fileURLString, cons
     maybeInitializeSandboxExtensionHandle(m_process, fileURL, resourceDirectoryURL, loadParameters.sandboxExtensionHandle);
     addPlatformLoadParameters(loadParameters);
 
-    m_process->assumeReadAccessToBaseURL(*this, resourceDirectoryURL);
 #if HAVE(SANDBOX_ISSUE_READ_EXTENSION_TO_PROCESS_BY_PID)
     if (m_process->isLaunching())
         m_process->send(Messages::WebPage::LoadRequestWaitingForPID(loadParameters, resourceDirectoryURL, m_identifier), m_webPageID);