Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
authoreustas@chromium.org <eustas@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Mar 2013 09:50:44 +0000 (09:50 +0000)
committereustas@chromium.org <eustas@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Mar 2013 09:50:44 +0000 (09:50 +0000)
https://bugs.webkit.org/show_bug.cgi?id=113032

Reviewed by Pavel Feldman.

To move overview window user could drag-n-drop over
time "ribbon" on OverviewGrid.

This feature is hard to discover.

Setting "move" cursor will make this feature more discoverable.

* inspector/front-end/inspectorCommon.css:
Set "move" cursor to draggable area.
* inspector/front-end/OverviewGrid.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@146753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/OverviewGrid.js
Source/WebCore/inspector/front-end/inspectorCommon.css

index dbaa757..aee0f51 100644 (file)
@@ -1,5 +1,23 @@
 2013-03-25  Eugene Klyuchnikov  <eustas@chromium.org>
 
+        Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
+        https://bugs.webkit.org/show_bug.cgi?id=113032
+
+        Reviewed by Pavel Feldman.
+
+        To move overview window user could drag-n-drop over
+        time "ribbon" on OverviewGrid.
+
+        This feature is hard to discover.
+
+        Setting "move" cursor will make this feature more discoverable.
+
+        * inspector/front-end/inspectorCommon.css:
+        Set "move" cursor to draggable area.
+        * inspector/front-end/OverviewGrid.js: Ditto.
+
+2013-03-25  Eugene Klyuchnikov  <eustas@chromium.org>
+
         Web Inspector: [Profiles] Remove unused private member.
         https://bugs.webkit.org/show_bug.cgi?id=113015
 
index b20aba7..a9784ff 100644 (file)
@@ -179,7 +179,7 @@ WebInspector.OverviewGrid.Window = function(parentElement, dividersLabelBarEleme
     this._dividersLabelBarElement = dividersLabelBarElement;
 
     WebInspector.installDragHandle(this._parentElement, this._startWindowSelectorDragging.bind(this), this._windowSelectorDragging.bind(this), this._endWindowSelectorDragging.bind(this), "ew-resize");
-    WebInspector.installDragHandle(this._dividersLabelBarElement, this._startWindowDragging.bind(this), this._windowDragging.bind(this), this._endWindowDragging.bind(this), "ew-resize");
+    WebInspector.installDragHandle(this._dividersLabelBarElement, this._startWindowDragging.bind(this), this._windowDragging.bind(this), this._endWindowDragging.bind(this), "move");
 
     this.windowLeft = 0.0;
     this.windowRight = 1.0;
index e7862a0..c3b9f9a 100644 (file)
@@ -90,6 +90,7 @@ iframe.view {
     height: 20px;
     z-index: 200;
     pointer-events: none;
+    cursor: move;
 }
 
 .resources-divider {