Modern media controls don't update their rendering correctly
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Oct 2016 21:03:03 +0000 (21:03 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Oct 2016 21:03:03 +0000 (21:03 +0000)
https://bugs.webkit.org/show_bug.cgi?id=163603
<rdar://problem/28826022>

Patch by Antoine Quint <graouts@apple.com> on 2016-10-18
Reviewed by Dean Jackson.

There are rendering issues when we use an absolutely-positioned element
as the top-most element in a media element's shadow root (webkit.org/b/163592).
Since we only need for that element to be positioned, we can use "position: relative"
instead, which removes the rendering issues.

* Modules/modern-media-controls/controls/media-controls.css:
(.media-controls):
(.media-controls,): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@207488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/modern-media-controls/controls/media-controls.css

index ba5fa27..d41dc06 100644 (file)
@@ -1,3 +1,20 @@
+2016-10-18  Antoine Quint  <graouts@apple.com>
+
+        Modern media controls don't update their rendering correctly
+        https://bugs.webkit.org/show_bug.cgi?id=163603
+        <rdar://problem/28826022>
+
+        Reviewed by Dean Jackson.
+
+        There are rendering issues when we use an absolutely-positioned element
+        as the top-most element in a media element's shadow root (webkit.org/b/163592).
+        Since we only need for that element to be positioned, we can use "position: relative"
+        instead, which removes the rendering issues.
+
+        * Modules/modern-media-controls/controls/media-controls.css:
+        (.media-controls):
+        (.media-controls,): Deleted.
+
 2016-10-18  Dean Jackson  <dino@apple.com>
 
         Add preliminary support for extended colors to WebCore::Color
index dbd0448..fe6d27f 100644 (file)
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-.media-controls,
+/* We need to use relative positioning due to webkit.org/b/163603 */
+.media-controls {
+    position: relative;
+}
+
 .media-controls > .controls-bar {
     position: absolute;
 }