Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Mar 2019 16:57:38 +0000 (16:57 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Mar 2019 16:57:38 +0000 (16:57 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196254
<rdar://problem/49124334>

Reviewed by Dean Jackson.

Source/WebCore:

* page/Quirks.cpp:
(WebCore::Quirks::shouldMousemoveEventHandlingPreventDefault const): Deleted.
* page/Quirks.h:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setMouseEventsSimulationEnabled):
(WebCore::RuntimeEnabledFeatures::mousemoveEventHandlingPreventsDefaultEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMousemoveEventHandlingPreventsDefaultEnabled): Deleted.

Source/WebKit:

* Shared/WebPreferences.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/page/Quirks.cpp
Source/WebCore/page/Quirks.h
Source/WebCore/page/RuntimeEnabledFeatures.h
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml

index 47d0ff7..6b429a1 100644 (file)
@@ -1,3 +1,19 @@
+2019-03-26  Antoine Quint  <graouts@apple.com>
+
+        Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
+        https://bugs.webkit.org/show_bug.cgi?id=196254
+        <rdar://problem/49124334>
+
+        Reviewed by Dean Jackson.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldMousemoveEventHandlingPreventDefault const): Deleted.
+        * page/Quirks.h:
+        * page/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::setMouseEventsSimulationEnabled):
+        (WebCore::RuntimeEnabledFeatures::mousemoveEventHandlingPreventsDefaultEnabled const): Deleted.
+        (WebCore::RuntimeEnabledFeatures::setMousemoveEventHandlingPreventsDefaultEnabled): Deleted.
+
 2019-03-26  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r243493.
index c501deb..1bf35c8 100644 (file)
@@ -200,9 +200,4 @@ bool Quirks::shouldDispatchSimulateMouseEvents() const
     return false;
 }
 
-bool Quirks::shouldMousemoveEventHandlingPreventDefault() const
-{
-    return false;
-}
-
 }
index 31d6004..891184b 100644 (file)
@@ -46,7 +46,6 @@ public:
     bool hasBrokenEncryptedMediaAPISupportQuirk() const;
     bool hasWebSQLSupportQuirk() const;
     bool shouldDispatchSimulateMouseEvents() const;
-    bool shouldMousemoveEventHandlingPreventDefault() const;
 
     WEBCORE_EXPORT bool isTouchBarUpdateSupressedForHiddenContentEditable() const;
     WEBCORE_EXPORT bool isNeverRichlyEditableForTouchBar() const;
index 394bf67..0e9c86f 100644 (file)
@@ -350,9 +350,6 @@ public:
 #if ENABLE(TOUCH_EVENTS)
     bool mouseEventsSimulationEnabled() const { return m_mouseEventsSimulationEnabled; }
     void setMouseEventsSimulationEnabled(bool isEnabled) { m_mouseEventsSimulationEnabled = isEnabled; }
-
-    bool mousemoveEventHandlingPreventsDefaultEnabled() const { return m_mousemoveEventHandlingPreventsDefaultEnabled; }
-    void setMousemoveEventHandlingPreventsDefaultEnabled(bool isEnabled) { m_mousemoveEventHandlingPreventsDefaultEnabled = isEnabled; }
 #endif
     
     bool referrerPolicyAttributeEnabled() const { return m_referrerPolicyAttributeEnabled; }
@@ -536,7 +533,6 @@ private:
 
 #if ENABLE(TOUCH_EVENTS)
     bool m_mouseEventsSimulationEnabled { false };
-    bool m_mousemoveEventHandlingPreventsDefaultEnabled { false };
 #endif
 
     bool m_isITPDatabaseEnabled { false };
index fe1a3b6..39803be 100644 (file)
@@ -1,3 +1,13 @@
+2019-03-26  Antoine Quint  <graouts@apple.com>
+
+        Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
+        https://bugs.webkit.org/show_bug.cgi?id=196254
+        <rdar://problem/49124334>
+
+        Reviewed by Dean Jackson.
+
+        * Shared/WebPreferences.yaml:
+
 2019-03-26  Philippe Normand  <pnormand@igalia.com>
 
         [WPE][Qt] Uninitialized racy ViewBackend
index f28cdfc..609d31f 100644 (file)
@@ -1611,15 +1611,6 @@ MouseEventsSimulationEnabled:
   category: internal
   condition: ENABLE(TOUCH_EVENTS)
 
-MousemoveEventHandlingPreventsDefaultEnabled:
-  type: bool
-  defaultValue: false
-  humanReadableName: "Prevent default for mousemove events"
-  humanReadableDescription: "Allows handling of mousemove events to implicitly call preventDefault() on iOS"
-  webcoreBinding: RuntimeEnabledFeatures
-  category: internal
-  condition: ENABLE(TOUCH_EVENTS)
-
 ReferrerPolicyAttributeEnabled:
   type: bool
   defaultValue: false