[CMake] Remove the definition of WTF_PLATFORM_WIN from the build system
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 24 Jan 2013 08:46:15 +0000 (08:46 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 24 Jan 2013 08:46:15 +0000 (08:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=101635

Patch by Soo-Hyun Choi <s.choi@hackerslab.eu> on 2013-01-24
Reviewed by Laszlo Gombos.

WTF_PLATFORM_WIN defined twice: Source/cmake/OptionsWindows.cmake and in
Source/WTF/wtf/Platform.h.
It would be more future-proof to have it only defined in common C++ code in
Platform.h.

* Source/cmake/OptionsWindows.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
Source/cmake/OptionsWindows.cmake

index c209976..9f9793c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2013-01-24  Soo-Hyun Choi  <s.choi@hackerslab.eu>
+
+        [CMake] Remove the definition of WTF_PLATFORM_WIN from the build system
+        https://bugs.webkit.org/show_bug.cgi?id=101635
+
+        Reviewed by Laszlo Gombos.
+
+        WTF_PLATFORM_WIN defined twice: Source/cmake/OptionsWindows.cmake and in
+        Source/WTF/wtf/Platform.h.
+        It would be more future-proof to have it only defined in common C++ code in
+        Platform.h.
+
+        * Source/cmake/OptionsWindows.cmake:
+
 2013-01-23  Zan Dobersek  <zdobersek@igalia.com>
 
         Unreviewed.
index cc29c80..c932e10 100644 (file)
@@ -1,6 +1,3 @@
-add_definitions(-DWTF_PLATFORM_WIN=1)
-set(WTF_PLATFORM_WIN 1)
-
 add_definitions(-D_HAS_EXCEPTIONS=0 -DNOMINMAX -DUNICODE)
 
 include_directories(${JAVASCRIPTCORE_DIR}/os-win32)