[ios-simulator] Unskip media/modern-media-controls/audio/audio-controls-metrics.html
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Mar 2017 23:10:38 +0000 (23:10 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Mar 2017 23:10:38 +0000 (23:10 +0000)
https://bugs.webkit.org/show_bug.cgi?id=167258
Source/WebCore:

<rdar://problem/30282740>

We weren't enforcing the min-width to be 200px as well as the default width, and the
UA stylesheet would override it. Setting a default min-width that trumps the UA
stylesheet makes the test work correctly on iOS and we can safely unskip this test.

Patch by Antoine Quint <graouts@apple.com> on 2017-03-01
Reviewed by Jon Lee.

* Modules/modern-media-controls/controls/media-controls.css:
(:host(audio)):

LayoutTests:

Patch by Antoine Quint <graouts@apple.com> on 2017-03-01
Reviewed by Jon Lee.

Unskip test now that we can pass it reliably.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/ios-simulator-wk2/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/Modules/modern-media-controls/controls/media-controls.css

index 13dbedc..9ea8089 100644 (file)
@@ -1,5 +1,16 @@
 2017-03-01  Antoine Quint  <graouts@apple.com>
 
+        [ios-simulator] Unskip media/modern-media-controls/audio/audio-controls-metrics.html
+        https://bugs.webkit.org/show_bug.cgi?id=167258
+
+        Reviewed by Jon Lee.
+
+        Unskip test now that we can pass it reliably.
+
+        * platform/ios-simulator-wk2/TestExpectations:
+
+2017-03-01  Antoine Quint  <graouts@apple.com>
+
         LayoutTest media/modern-media-controls/play-pause-button/play-pause-button.html is a flaky timeout
         https://bugs.webkit.org/show_bug.cgi?id=167447
         <rdar://problem/30790539>
index 7e18b12..85ce958 100644 (file)
@@ -1914,6 +1914,4 @@ fast/css/deferred-parsing/hover-test.html [ Skip ]
 
 webkit.org/b/166025 http/tests/fetch/fetching-same-resource-with-diffferent-options.html [ Pass Failure ]
 
-webkit.org/b/167258 media/modern-media-controls/audio/audio-controls-metrics.html [ Skip ]
-
 imported/w3c/web-platform-tests/webrtc [ Skip ]
index 10ca2ec..3819d23 100644 (file)
@@ -1,3 +1,18 @@
+2017-03-01  Antoine Quint  <graouts@apple.com>
+
+        [ios-simulator] Unskip media/modern-media-controls/audio/audio-controls-metrics.html
+        https://bugs.webkit.org/show_bug.cgi?id=167258
+        <rdar://problem/30282740>
+
+        We weren't enforcing the min-width to be 200px as well as the default width, and the
+        UA stylesheet would override it. Setting a default min-width that trumps the UA
+        stylesheet makes the test work correctly on iOS and we can safely unskip this test.
+
+        Reviewed by Jon Lee.
+
+        * Modules/modern-media-controls/controls/media-controls.css:
+        (:host(audio)):
+
 2017-03-01  Javier Fernandez  <jfernandez@igalia.com>
 
         Missing 'specification' section in the place-content shorthand