[iOS] Remove unused keyboard code in WKSelectPopover class.
authorenrica@apple.com <enrica@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Mar 2015 23:37:34 +0000 (23:37 +0000)
committerenrica@apple.com <enrica@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Mar 2015 23:37:34 +0000 (23:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=143021

Reviewed by Joseph Pecoraro.

WKSelectPopover created an instance of UIKeyboard that was
initialized in initWithView but never used. Removing the
obsolete code.

* UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectPopover initWithView:hasGroups:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/ios/forms/WKFormSelectPopover.mm

index 11eed6e..3ecf9d9 100644 (file)
@@ -1,3 +1,17 @@
+2015-03-24  Enrica Casucci  <enrica@apple.com>
+
+        [iOS] Remove unused keyboard code in WKSelectPopover class.
+        https://bugs.webkit.org/show_bug.cgi?id=143021
+
+        Reviewed by Joseph Pecoraro.
+
+        WKSelectPopover created an instance of UIKeyboard that was
+        initialized in initWithView but never used. Removing the
+        obsolete code.
+
+        * UIProcess/ios/forms/WKFormSelectPopover.mm:
+        (-[WKSelectPopover initWithView:hasGroups:]):
+
 2015-03-24  Dan Bernstein  <mitz@apple.com>
 
         WebKit2 part of <rdar://problem/20282863> Transforms are flattened in snapshots of on-screen WKWebViews
index 9ec1516..2c6b1ce 100644 (file)
@@ -369,7 +369,6 @@ static NSString *stringWithWritingDirection(NSString *string, UITextWritingDirec
 @implementation WKSelectPopover {
     WKContentView *_view;
     RetainPtr<WKSelectTableViewController> _tableViewController;
-    RetainPtr<UIKeyboard> _keyboard;
 }
 
 - (instancetype)initWithView:(WKContentView *)view hasGroups:(BOOL)hasGroups
@@ -381,7 +380,6 @@ static NSString *stringWithWritingDirection(NSString *string, UITextWritingDirec
     CGRect frame;
     frame.origin = CGPointZero;
     frame.size = [UIKeyboard defaultSizeForInterfaceOrientation:[UIApp interfaceOrientation]];
-    _keyboard = adoptNS([[UIKeyboard alloc] initWithFrame:frame]);
 
     _tableViewController = adoptNS([[WKSelectTableViewController alloc] initWithView:view hasGroups:hasGroups]);
     [_tableViewController setPopover:self];
@@ -407,10 +405,6 @@ static NSString *stringWithWritingDirection(NSString *string, UITextWritingDirec
     [navController release];
     
     [[UIKeyboardImpl sharedInstance] setDelegate:_tableViewController.get()];
-    [_keyboard setSize:[UIKeyboard defaultSizeForInterfaceOrientation:[UIApp interfaceOrientation]]];
-    [_keyboard prepareForGeometryChange];
-    [_keyboard geometryChangeDone:NO];
-    [_keyboard activate];
     
     return self;
 }