-Wunused-variable in RenderLayer::updateScrollableAreaSet
authormcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Oct 2018 11:03:48 +0000 (11:03 +0000)
committermcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Oct 2018 11:03:48 +0000 (11:03 +0000)
https://bugs.webkit.org/show_bug.cgi?id=190200

Reviewed by Yusuke Suzuki.

Source/WebCore:

Pass it through UNUSED_VARIABLE().

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):

Source/WTF:

Add a new UNUSED_VARIABLE() macro. It's the same as UNUSED_PARAM(), just named differently.

* wtf/Compiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WTF/ChangeLog
Source/WTF/wtf/Compiler.h
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderLayer.cpp

index 16cb524..515df4d 100644 (file)
@@ -1,3 +1,14 @@
+2018-10-03  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        -Wunused-variable in RenderLayer::updateScrollableAreaSet
+        https://bugs.webkit.org/show_bug.cgi?id=190200
+
+        Reviewed by Yusuke Suzuki.
+
+        Add a new UNUSED_VARIABLE() macro. It's the same as UNUSED_PARAM(), just named differently.
+
+        * wtf/Compiler.h:
+
 2018-10-01  Dean Jackson  <dino@apple.com>
 
         [macOS] Switching to discrete GPU should be done in the UI process
index fb1898d..ab19232 100644 (file)
 #define UNUSED_PARAM(variable) (void)variable
 #endif
 
+/* UNUSED_VARIABLE */
+#if !defined(UNUSED_VARIABLE)
+#define UNUSED_VARIABLE(variable) UNUSED_PARAM(variable)
+#endif
+
 /* WARN_UNUSED_RETURN */
 
 #if !defined(WARN_UNUSED_RETURN) && COMPILER(GCC_COMPATIBLE)
index 28c24ec..0708190 100644 (file)
@@ -1,3 +1,15 @@
+2018-10-03  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        -Wunused-variable in RenderLayer::updateScrollableAreaSet
+        https://bugs.webkit.org/show_bug.cgi?id=190200
+
+        Reviewed by Yusuke Suzuki.
+
+        Pass it through UNUSED_VARIABLE().
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::calculateClipRects const):
+
 2018-10-03  Zan Dobersek  <zdobersek@igalia.com>
 
         Ref<FetchResponse> use-after-move in DOMCache::put()
index 1086321..1d63713 100644 (file)
@@ -6364,6 +6364,8 @@ void RenderLayer::updateScrollableAreaSet(bool hasOverflow)
             unregisterAsTouchEventListenerForScrolling();
         }
     }
+#else
+    UNUSED_VARIABLE(addedOrRemoved);
 #endif
 }