Reviewed and landed by ggaren.
authorggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 2 Jul 2006 23:36:57 +0000 (23:36 +0000)
committerggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 2 Jul 2006 23:36:57 +0000 (23:36 +0000)
        * platform/gdk/TransferJobManager.cpp
        Fixed broken dowload logic
        * platform/gdk/ScrollViewGdk.cpp
        Add comment that scrollbarSize is a temporary variable
        * Projects/gdk/webcore-gdk.bkl
        Defined NDEBUG build executable is miscompiled otherwise
        * WebCoreSources.bkl
        added icon/SiteIcon.cpp editing/IndentOutdentCommand.cpp
        html/HTMLViewSourceDocument.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/Projects/gdk/webcore-gdk.bkl
WebCore/WebCoreSources.bkl
WebCore/platform/gdk/ScrollViewGdk.cpp
WebCore/platform/gdk/TransferJobManager.cpp

index c245e3d..a8b6e62 100644 (file)
@@ -1,3 +1,17 @@
+2006-07-02  Mike Emmel  <mike.emmel@gmail.com>
+
+        Reviewed and landed by ggaren.
+
+        * platform/gdk/TransferJobManager.cpp
+        Fixed broken dowload logic
+        * platform/gdk/ScrollViewGdk.cpp 
+        Add comment that scrollbarSize is a temporary variable
+        * Projects/gdk/webcore-gdk.bkl
+        Defined NDEBUG build executable is miscompiled otherwise
+        * WebCoreSources.bkl
+        added icon/SiteIcon.cpp editing/IndentOutdentCommand.cpp 
+        html/HTMLViewSourceDocument.cpp
+
 2006-07-02  Shawn Stricker  <kb1ibt@gmail.com>
 
         Reviewed by Timothy Hatcher.  Build fix for Linux.
index 41c1621..855a618 100644 (file)
@@ -58,6 +58,8 @@
                <include>platform/cairo</include>
            <include>$(SRCDIR)/kcanvas/device/cairo</include>
        <define>XPATH_SUPPORT</define>
+        <!-- gdk build broken with without NDEBUG defined -->
+       <define>NDEBUG</define>
  
         <sources>              
           platform/cairo/GraphicsContextCairo.cpp
index a62c6f9..2509291 100644 (file)
                icon/IconDatabase.cpp
                icon/SQLDatabase.cpp
                icon/SQLStatement.cpp
+               icon/SiteIcon.cpp
        </set>
 
        <set append="1" var="WEBCORE_SOURCES_BRIDGE">
                editing/FormatBlockCommand.cpp
                editing/htmlediting.cpp
                editing/HTMLInterchange.cpp
+               editing/IndentOutdentCommand.cpp
                editing/InsertIntoTextNodeCommand.cpp
                editing/InsertLineBreakCommand.cpp
                editing/InsertListCommand.cpp
 
        </set>
        <set append="1" var="WEBCORE_SOURCES_HTML">
-               
+
                html/CanvasGradient.cpp
                html/CanvasPattern.cpp
                html/CanvasRenderingContext2D.cpp
                html/HTMLTitleElement.cpp
                html/HTMLTokenizer.cpp
                html/HTMLUListElement.cpp
+           html/HTMLViewSourceDocument.cpp     
 
        </set>
        <set append="1" var="WEBCORE_SOURCES_BINDINGS">
index c6099b4..452f8fe 100644 (file)
@@ -42,6 +42,7 @@ using namespace std;
 
 namespace WebCore {
 
+//hack to simulate scroll bars
 const int scrollbarSize = 10;
 
 class ScrollView::ScrollViewPrivate
index 216f526..bf6ee6c 100644 (file)
@@ -79,7 +79,6 @@ void TransferJobManager::downloadTimerCallback(Timer<TransferJobManager>* timer)
         m_downloadTimer.stop();
         return;
     }
-
     if (m_useSimple) {
         for (HashSet<TransferJob*>::iterator it = jobs->begin(); it != jobs->end(); ++it) {
             TransferJob* job = *it;
@@ -108,11 +107,13 @@ void TransferJobManager::downloadTimerCallback(Timer<TransferJobManager>* timer)
         switch (retval) {
             case -1:                        // select error
 #ifndef NDEBUG
-                printf("%s, select error(?)\n", __PRETTY_FUNCTION__);
+                printf("%s, select error(%d)\n", __PRETTY_FUNCTION__,retval);
 #endif
                 /* fallthrough*/
             case 0:                 // select timeout
-                printf("%s, select timout\n", __PRETTY_FUNCTION__);
+#ifndef NDEBUG
+                printf("%s, select timeout %d\n", __PRETTY_FUNCTION__,retval);
+#endif
                 /* fallthrough. this can be the first perform to be made */
             default:                        // 1+ descriptors have data
                 while (CURLM_CALL_MULTI_PERFORM == curl_multi_perform(curlMultiHandle, &nrunning))
@@ -154,10 +155,10 @@ void TransferJobManager::downloadTimerCallback(Timer<TransferJobManager>* timer)
                 }
             }
 
-            if (!jobs->isEmpty())
-                m_downloadTimer.startOneShot(pollTimeSeconds);
         }
     }
+    if (!jobs->isEmpty())
+        m_downloadTimer.startOneShot(pollTimeSeconds);
 }
 
 void TransferJobManager::remove(TransferJob* job)
@@ -204,11 +205,12 @@ void TransferJobManager::add(TransferJob* job)
         // timeout will occur and do curl_multi_perform
         if (ret && ret != CURLM_CALL_MULTI_PERFORM) {
             printf("Error %d starting job %s\n", ret, d->URL.url().ascii());
-            cancel(job);
+            job->setError(1);
+            startTimer =false;
         } else
             jobs->add(job);
     }
-    if (!jobs->isEmpty())
+    if (startTimer)
         m_downloadTimer.startOneShot(pollTimeSeconds);
 }