Modern IDB: storage/indexeddb/create-and-remove-object-store.html fails.
authorbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 1 Dec 2015 18:30:20 +0000 (18:30 +0000)
committerbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 1 Dec 2015 18:30:20 +0000 (18:30 +0000)
https://bugs.webkit.org/show_bug.cgi?id=151704

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (At least one previously failing test now passes).

* Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::deleteObjectStore):

LayoutTests:

* platform/mac-wk1/TestExpectations:
* storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@192891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac-wk1/TestExpectations
LayoutTests/storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp

index 80eda89..487eff1 100644 (file)
@@ -1,5 +1,15 @@
 2015-12-01  Brady Eidson  <beidson@apple.com>
 
+        Modern IDB: storage/indexeddb/create-and-remove-object-store.html fails.
+        https://bugs.webkit.org/show_bug.cgi?id=151704
+
+        Reviewed by Alex Christensen.
+
+        * platform/mac-wk1/TestExpectations:
+        * storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt:
+
+2015-12-01  Brady Eidson  <beidson@apple.com>
+
         Modern IDB: storage/indexeddb/basics.html fails.
         https://bugs.webkit.org/show_bug.cgi?id=151694
 
index d69aaf9..8fd1aa1 100644 (file)
@@ -70,9 +70,10 @@ crypto/subtle/rsa-indexeddb.html
 crypto/subtle/rsa-indexeddb-non-exportable.html
 inspector/indexeddb
 
-# But Modern IndexedDB is.
+# Tests that are skipped above but that pass in Modern IDB are unskipped below.
 storage/indexeddb/aborted-versionchange-closes.html [ Pass ]
 storage/indexeddb/basics.html [ Pass ]
+storage/indexeddb/create-and-remove-object-store.html
 storage/indexeddb/cursor-cast.html [ Pass ]
 storage/indexeddb/cursor-finished.html [ Pass ]
 storage/indexeddb/modern [ Pass ]
index 27ffa74..ac05859 100644 (file)
@@ -1,7 +1,7 @@
 ALERT: Initial upgrade needed: Old version - 0 New version - 1
 ALERT: Initial upgrade versionchange transaction complete
 ALERT: readwrite put success - about to try to delete an objectstore
-ALERT: Failed to deleteObjectStore without a versionchange transaction - Error: InvalidStateError: DOM Exception 11
+ALERT: Failed to deleteObjectStore without a versionchange transaction - Error: InvalidStateError: DOM IDBDatabase Exception 11
 ALERT: readwrite transaction complete
 ALERT: Second upgrade needed: Old version - 1 New version - 2
 ALERT: Failed to deleteObjectStore with a non-existent objectstore - Error: NotFoundError: DOM IDBDatabase Exception 8
index de097ab..604d5b8 100644 (file)
@@ -1,5 +1,17 @@
 2015-12-01  Brady Eidson  <beidson@apple.com>
 
+        Modern IDB: storage/indexeddb/create-and-remove-object-store.html fails.
+        https://bugs.webkit.org/show_bug.cgi?id=151704
+
+        Reviewed by Alex Christensen.
+
+        No new tests (At least one previously failing test now passes).
+
+        * Modules/indexeddb/client/IDBDatabaseImpl.cpp:
+        (WebCore::IDBClient::IDBDatabase::deleteObjectStore):
+
+2015-12-01  Brady Eidson  <beidson@apple.com>
+
         Modern IDB: storage/indexeddb/basics.html fails.
         https://bugs.webkit.org/show_bug.cgi?id=151694
 
index 3095e98..5303a6b 100644 (file)
@@ -190,7 +190,7 @@ void IDBDatabase::deleteObjectStore(const String& objectStoreName, ExceptionCode
     LOG(IndexedDB, "IDBDatabase::deleteObjectStore");
 
     if (!m_versionChangeTransaction) {
-        ec = INVALID_STATE_ERR;
+        ec = IDBDatabaseException::InvalidStateError;
         return;
     }