Web Inspector: REGRESSION(r238602): Elements: changing selection no longer highlights...
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Dec 2018 20:07:09 +0000 (20:07 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Dec 2018 20:07:09 +0000 (20:07 +0000)
https://bugs.webkit.org/show_bug.cgi?id=192354
<rdar://problem/46444438>

Reviewed by Joseph Pecoraro.

* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._treeKeyDown):
(WI.TreeOutline.prototype._handleMouseDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

index b5d9261..9271caa 100644 (file)
@@ -1,3 +1,15 @@
+2018-12-04  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: REGRESSION(r238602): Elements: changing selection no longer highlights the selected node
+        https://bugs.webkit.org/show_bug.cgi?id=192354
+        <rdar://problem/46444438>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/TreeOutline.js:
+        (WI.TreeOutline.prototype._treeKeyDown):
+        (WI.TreeOutline.prototype._handleMouseDown):
+
 2018-12-04  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: REGRESSION(r238330): Timeline auto-capture does not work after page transition
index ed7e51e..72f2cfd 100644 (file)
@@ -609,8 +609,11 @@ WI.TreeOutline = class TreeOutline extends WI.Object
             }
         }
 
-        if (!handled)
+        if (!handled) {
+            this._itemWasSelectedByUser = true;
             handled = this._selectionController.handleKeyDown(event);
+            this._itemWasSelectedByUser = false;
+        }
 
         if (nextSelectedElement) {
             nextSelectedElement.reveal();
@@ -1000,7 +1003,9 @@ WI.TreeOutline = class TreeOutline extends WI.Object
         if (isNaN(index))
             return;
 
+        this._itemWasSelectedByUser = true;
         this._selectionController.handleItemMouseDown(index, event);
+        this._itemWasSelectedByUser = false;
     }
 
     _indexOfTreeElement(treeElement)