Style Checker false pass.
authorossy@webkit.org <ossy@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 Dec 2013 12:30:22 +0000 (12:30 +0000)
committerossy@webkit.org <ossy@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 Dec 2013 12:30:22 +0000 (12:30 +0000)
https://bugs.webkit.org/show_bug.cgi?id=112456

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-03
Reviewed by Csaba Osztrogon√°c.

* Scripts/webkitpy/style/checkers/changelog.py:
(ChangeLogChecker.check_entry):
simple regex fix to check "No new tests (...)."
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.test_no_new_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/style/checkers/changelog.py
Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py

index 1854d29..48a3e2d 100644 (file)
@@ -1,3 +1,16 @@
+2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
+
+        Style Checker false pass.
+        https://bugs.webkit.org/show_bug.cgi?id=112456
+
+        Reviewed by Csaba Osztrogon√°c.
+
+        * Scripts/webkitpy/style/checkers/changelog.py:
+        (ChangeLogChecker.check_entry):
+        simple regex fix to check "No new tests (...)."
+        * Scripts/webkitpy/style/checkers/changelog_unittest.py:
+        (ChangeLogCheckerTest.test_no_new_tests):
+
 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
 
         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
index 61dadb4..dce85af 100644 (file)
@@ -65,11 +65,11 @@ class ChangeLogChecker(object):
                                     "changelog/filechangedescriptionwhitespace", 5,
                                     "Need whitespace between colon and description")
 
-        # check for a lingering "No new tests. (OOPS!)" left over from prepare-changeLog.
+        # check for a lingering "No new tests (OOPS!)." left over from prepare-changeLog.
         line_no = first_line_checked - 1
         for line in entry_lines:
             line_no = line_no + 1
-            if match('\s*No new tests. \(OOPS!\)$', line):
+            if match('\s*No new tests \(OOPS!\)\.$', line):
                 self.handle_style_error(line_no,
                                         "changelog/nonewtests", 5,
                                         "You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.")
index 0ec0ec2..26904bb 100644 (file)
@@ -125,7 +125,7 @@ class ChangeLogCheckerTest(unittest.TestCase):
                           '        ExampleBug\n'
                           '        http://bugs.webkit.org/show_bug.cgi?id=12345\n'
                           '\n'
-                          '        No new tests. (OOPS!)\n'
+                          '        No new tests (OOPS!).\n'
                           '        *  Source/Tools/random-script.py: Fixed')
 
     def test_no_error(self):