Add OVERRIDE and deinline virtual getters on *PlatformGestureCurve
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Aug 2012 04:31:34 +0000 (04:31 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Aug 2012 04:31:34 +0000 (04:31 +0000)
https://bugs.webkit.org/show_bug.cgi?id=94887

Patch by James Robinson <jamesr@chromium.org> on 2012-08-23
Reviewed by Dirk Pranke.

This makes clang happy. Clang makes me happy. By induction, this makes me happy.

* platform/TouchpadFlingPlatformGestureCurve.cpp:
(WebCore::TouchpadFlingPlatformGestureCurve::debugName):
(WebCore):
* platform/TouchpadFlingPlatformGestureCurve.h:
(TouchpadFlingPlatformGestureCurve):
* platform/WheelFlingPlatformGestureCurve.cpp:
(WebCore::WheelFlingPlatformGestureCurve::debugName):
(WebCore):
* platform/WheelFlingPlatformGestureCurve.h:
(WheelFlingPlatformGestureCurve):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.cpp
Source/WebCore/platform/TouchpadFlingPlatformGestureCurve.h
Source/WebCore/platform/WheelFlingPlatformGestureCurve.cpp
Source/WebCore/platform/WheelFlingPlatformGestureCurve.h

index c23acac..74af28e 100644 (file)
@@ -1,3 +1,23 @@
+2012-08-23  James Robinson  <jamesr@chromium.org>
+
+        Add OVERRIDE and deinline virtual getters on *PlatformGestureCurve
+        https://bugs.webkit.org/show_bug.cgi?id=94887
+
+        Reviewed by Dirk Pranke.
+
+        This makes clang happy. Clang makes me happy. By induction, this makes me happy.
+
+        * platform/TouchpadFlingPlatformGestureCurve.cpp:
+        (WebCore::TouchpadFlingPlatformGestureCurve::debugName):
+        (WebCore):
+        * platform/TouchpadFlingPlatformGestureCurve.h:
+        (TouchpadFlingPlatformGestureCurve):
+        * platform/WheelFlingPlatformGestureCurve.cpp:
+        (WebCore::WheelFlingPlatformGestureCurve::debugName):
+        (WebCore):
+        * platform/WheelFlingPlatformGestureCurve.h:
+        (WheelFlingPlatformGestureCurve):
+
 2012-08-23  Yoshifumi Inoue  <yosin@chromium.org>
 
         [Forms] Step mismatched value should be editable in multiple field time UI.
index 09f185a..b2bfbea 100644 (file)
@@ -129,6 +129,11 @@ TouchpadFlingPlatformGestureCurve::~TouchpadFlingPlatformGestureCurve()
 {
 }
 
+const char* TouchpadFlingPlatformGestureCurve::debugName() const
+{
+    return "TouchpadFling";
+}
+
 bool TouchpadFlingPlatformGestureCurve::apply(double time, PlatformGestureCurveTarget* target)
 {
     float displacement;
index 46b0aa5..e1c8557 100644 (file)
@@ -44,8 +44,8 @@ public:
     static PassOwnPtr<PlatformGestureCurve> create(const FloatPoint& velocity, float p0, float p1, float p2, float p3, float p4, float curveDuration, IntPoint cumulativeScroll = IntPoint());
     virtual ~TouchpadFlingPlatformGestureCurve();
 
-    virtual const char* debugName() const { return "TouchpadFling"; }
-    virtual bool apply(double monotonicTime, PlatformGestureCurveTarget*);
+    virtual const char* debugName() const OVERRIDE;
+    virtual bool apply(double monotonicTime, PlatformGestureCurveTarget*) OVERRIDE;
 
 private:
     TouchpadFlingPlatformGestureCurve(const FloatPoint& velocity, float p0, float p1, float p2, float p3, float p4, float curveDuration, const IntPoint& cumulativeScroll);
index c9f1732..73ffc38 100644 (file)
@@ -46,6 +46,11 @@ WheelFlingPlatformGestureCurve::~WheelFlingPlatformGestureCurve()
 {
 }
 
+const char* WheelFlingPlatformGestureCurve::debugName() const
+{
+    return "WheelFling";
+}
+
 bool WheelFlingPlatformGestureCurve::apply(double time, PlatformGestureCurveTarget* target)
 {
     // Use a Rayleigh distribution for the curve. This simulates a velocity profile
index 44d552a..96cfaca 100644 (file)
@@ -43,8 +43,8 @@ public:
     static PassOwnPtr<PlatformGestureCurve> create(const FloatPoint& velocity);
     virtual ~WheelFlingPlatformGestureCurve();
 
-    virtual const char* debugName() const { return "WheelFling"; }
-    virtual bool apply(double time, PlatformGestureCurveTarget*);
+    virtual const char* debugName() const OVERRIDE;
+    virtual bool apply(double time, PlatformGestureCurveTarget*) OVERRIDE;
 
 private:
     explicit WheelFlingPlatformGestureCurve(const FloatPoint& velocity);