REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 24 Jan 2018 20:48:32 +0000 (20:48 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 24 Jan 2018 20:48:32 +0000 (20:48 +0000)
https://bugs.webkit.org/show_bug.cgi?id=181400
<rdar://problem/36358768>

Reviewed by Joseph Pecoraro.

* BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
Always disable poisoning when running with --leaks, as this should work locally,
not just on bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@227547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Tools/ChangeLog
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

index eced149..9e2597e 100644 (file)
                     },
                     { "name": "Apple High Sierra (Leaks)", "type": "TestWebKit1Leaks", "builddir": "highsierra-leaks",
                       "platform": "mac-highsierra", "configuration": "release", "architectures": ["x86_64"],
-                      "additionalArguments": ["--no-retry-failures", "--no-sample-on-timeout", "--JSC_usePoisoning=0"],
+                      "additionalArguments": ["--no-retry-failures", "--no-sample-on-timeout"],
                       "slavenames": ["bot121"]
                     },
                     { "name": "Apple Sierra Debug (Build)", "type": "Build", "builddir": "sierra-debug",
index 2a60582..53be69c 100644 (file)
@@ -1,3 +1,17 @@
+2018-01-24  Alexey Proskuryakov  <ap@apple.com>
+
+        REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
+        https://bugs.webkit.org/show_bug.cgi?id=181400
+        <rdar://problem/36358768>
+
+        Reviewed by Joseph Pecoraro.
+
+        * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
+
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
+        Always disable poisoning when running with --leaks, as this should work locally,
+        not just on bots.
+
 2018-01-24  Daniel Bates  <dabates@apple.com>
 
         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
index 8e97516..86872c9 100755 (executable)
@@ -429,6 +429,9 @@ def _set_up_derived_options(port, options):
     if options.platform in ["gtk", "wpe"]:
         options.webkit_test_runner = True
 
+    if options.leaks:
+        options.additional_env_var.append("JSC_usePoisoning=0")
+        options.additional_env_var.append("__XPC_JSC_usePoisoning=0")
 
 def run(port, options, args, logging_stream):
     logger = logging.getLogger()