Enable keyboard in fullscreen.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Oct 2016 22:56:15 +0000 (22:56 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Oct 2016 22:56:15 +0000 (22:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=163146

Patch by Jeremy Jones <jeremyj@apple.com> on 2016-10-17
Reviewed by Jer Noble.

Allow keyboard in fullscreen.

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _supportsFullScreenForElement:withKeyboard:]):

Source/WebKit2:

* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::supportsFullScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@207439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebView/WebView.mm
Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/WebFullScreenManagerProxy.cpp

index 6ab7284..c3a9c1c 100644 (file)
@@ -1,3 +1,15 @@
+2016-10-17  Jeremy Jones  <jeremyj@apple.com>
+
+        Enable keyboard in fullscreen.
+        https://bugs.webkit.org/show_bug.cgi?id=163146
+
+        Reviewed by Jer Noble.
+
+        Allow keyboard in fullscreen.
+
+        * WebView/WebView.mm:
+        (-[WebView _supportsFullScreenForElement:withKeyboard:]):
+
 2016-10-17  Chris Dumez  <cdumez@apple.com>
 
         Move form.reportValidity() behind InteractiveFormValidation setting
index 74132f3..e9fdeaa 100644 (file)
@@ -8659,7 +8659,7 @@ bool LayerFlushController::flushLayers()
     if (![[self preferences] fullScreenEnabled])
         return NO;
 
-    return !withKeyboard;
+    return true;
 }
 
 - (void)_enterFullScreenForElement:(WebCore::Element*)element
index afeabb8..0f3b6b6 100644 (file)
@@ -1,3 +1,15 @@
+2016-10-17  Jeremy Jones  <jeremyj@apple.com>
+
+        Enable keyboard in fullscreen.
+        https://bugs.webkit.org/show_bug.cgi?id=163146
+
+        Reviewed by Jer Noble.
+
+        Allow keyboard in fullscreen.
+
+        * UIProcess/WebFullScreenManagerProxy.cpp:
+        (WebKit::WebFullScreenManagerProxy::supportsFullScreen):
+
 2016-10-17  Chris Dumez  <cdumez@apple.com>
 
         Move form.reportValidity() behind InteractiveFormValidation setting
index 4817f3f..1a1f981 100644 (file)
@@ -86,7 +86,7 @@ void WebFullScreenManagerProxy::requestExitFullScreen()
 
 void WebFullScreenManagerProxy::supportsFullScreen(bool withKeyboard, bool& supports)
 {
-    supports = !withKeyboard;
+    supports = true;
 }
 
 void WebFullScreenManagerProxy::saveScrollPosition()