[Cocoa] [GTK] RunLoop::Timer::isActive() is incorrect for timers while they are firing
authorggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Jul 2020 05:21:08 +0000 (05:21 +0000)
committerggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Jul 2020 05:21:08 +0000 (05:21 +0000)
https://bugs.webkit.org/show_bug.cgi?id=213771

Unreviewed assertion fix.

* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::timeOutTimerFired): Removed this ASSERT.
One-shot timers are not active while they are firing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp

index a6198d1..8459589 100644 (file)
@@ -1,3 +1,14 @@
+2020-06-30  Geoffrey Garen  <ggaren@apple.com>
+
+        [Cocoa] [GTK] RunLoop::Timer::isActive() is incorrect for timers while they are firing
+        https://bugs.webkit.org/show_bug.cgi?id=213771
+
+        Unreviewed assertion fix.
+
+        * UIProcess/WebAuthentication/AuthenticatorManager.cpp:
+        (WebKit::AuthenticatorManager::timeOutTimerFired): Removed this ASSERT.
+        One-shot timers are not active while they are firing.
+
 2020-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
 
         Several key event tests in fast/events/ios are failing after <rdar://problem/62197116>
index c7e2b78..680437b 100644 (file)
@@ -345,7 +345,6 @@ void AuthenticatorManager::initTimeOutTimer()
 
 void AuthenticatorManager::timeOutTimerFired()
 {
-    ASSERT(m_requestTimeOutTimer.isActive());
     invokePendingCompletionHandler((ExceptionData { NotAllowedError, "Operation timed out."_s }));
     clearState();
 }