Address Dean's comments in 154673.
authorjonlee@apple.com <jonlee@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 27 Feb 2016 04:43:57 +0000 (04:43 +0000)
committerjonlee@apple.com <jonlee@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 27 Feb 2016 04:43:57 +0000 (04:43 +0000)
* Animometer/developer.html:
* Animometer/resources/debug-runner/animometer.js:
* Animometer/resources/debug-runner/graph.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@197232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

PerformanceTests/Animometer/developer.html
PerformanceTests/Animometer/resources/debug-runner/animometer.js
PerformanceTests/Animometer/resources/debug-runner/graph.js
PerformanceTests/ChangeLog

index c065468..3b264fa 100644 (file)
@@ -13,7 +13,7 @@
     <script src="resources/runner/tests.js"></script>
     <script src="resources/debug-runner/tests.js" charset="utf-8"></script>
     <script src="resources/runner/animometer.js"></script>
-    <script src="resources/debug-runner/animometer.js"></script>
+    <script src="resources/debug-runner/animometer.js" charset="utf-8"></script>
 
     <script src="resources/runner/benchmark-runner.js"></script>
     <script src="resources/debug-runner/d3.min.js"></script>
index 4033379..8cb9ecd 100644 (file)
@@ -28,7 +28,7 @@ DeveloperResultsTable = Utilities.createSubclass(ResultsTable,
     _addGraphButton: function(td, testName, testResult, testData)
     {
         var button = Utilities.createElement("button", { class: "small-button" }, td);
-        button.textContent = Strings.text.graph + "...";
+        button.textContent = Strings.text.graph + "";
         button.testName = testName;
         button.testResult = testResult;
         button.testData = testData;
@@ -495,9 +495,9 @@ Utilities.extendObject(window.benchmarkController, {
         }
 
         var dashboard = benchmarkRunnerClient.results;
-        if (dashboard.options["adjustment"] == "ramp") {
+        if (dashboard.options["adjustment"] == "ramp")
             Headers.details[3].disabled = true;
-        else {
+        else {
             Headers.details[1].disabled = true;
             Headers.details[4].disabled = true;
         }
index 0aabcc9..d8952b5 100644 (file)
@@ -5,9 +5,9 @@ Utilities.extendObject(window.benchmarkController, {
     {
         var element = document.getElementById("test-graph-data");
         element.innerHTML = "";
-        element.testResult = testResult;
-        element.testData = testData;
-        element.options = options;
+        element._testResult = testResult;
+        element._testData = testData;
+        element._options = options;
         document.querySelector("hr").style.width = this.layoutCounter++ + "px";
 
         var margins = new Insets(30, 30, 30, 40);
@@ -561,7 +561,7 @@ Utilities.extendObject(window.benchmarkController, {
 
     onGraphTypeChanged: function() {
         var form = document.forms["graph-type"].elements;
-        var testResult = document.getElementById("test-graph-data").testResult;
+        var testResult = document.getElementById("test-graph-data")._testResult;
         var isTimeSelected = form["graph-type"].value == "time";
 
         benchmarkController._showOrHideNodes(isTimeSelected, "#time-graph");
index 36ae66e..6f9e0fe 100644 (file)
@@ -1,3 +1,11 @@
+2016-02-26  Jon Lee  <jonlee@apple.com>
+
+        Address Dean's comments in 154673.
+
+        * Animometer/developer.html:
+        * Animometer/resources/debug-runner/animometer.js:
+        * Animometer/resources/debug-runner/graph.js:
+
 2016-02-25  Jon Lee  <jonlee@apple.com>
 
         Update animation benchmark and tests