Stop trying to support building JSC with clang 3.8
authormcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 1 Apr 2019 17:27:53 +0000 (17:27 +0000)
committermcatanzaro@igalia.com <mcatanzaro@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 1 Apr 2019 17:27:53 +0000 (17:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=195947
<rdar://problem/49069219>

Reviewed by Darin Adler.

It seems WebKit hasn't built with clang 3.8 in a while, no devs are using this compiler, we
don't know how much effort it would be to make JSC work again, and it's making the code
Source/JavaScriptCore:

worse. Remove my hacks to support clang 3.8 from JSC.

* bindings/ScriptValue.cpp:
(Inspector::jsToInspectorValue):
* bytecode/GetterSetterAccessCase.cpp:
(JSC::GetterSetterAccessCase::create):
(JSC::GetterSetterAccessCase::clone const):
* bytecode/InstanceOfAccessCase.cpp:
(JSC::InstanceOfAccessCase::clone const):
* bytecode/IntrinsicGetterAccessCase.cpp:
(JSC::IntrinsicGetterAccessCase::clone const):
* bytecode/ModuleNamespaceAccessCase.cpp:
(JSC::ModuleNamespaceAccessCase::clone const):
* bytecode/ProxyableAccessCase.cpp:
(JSC::ProxyableAccessCase::clone const):

Source/WTF:

worse. Remove my hacks to support clang 3.8 from WTF.

* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::allocate):
* wtf/text/StringConcatenate.h:
(WTF::tryMakeStringFromAdapters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/bindings/ScriptValue.cpp
Source/JavaScriptCore/bytecode/GetterSetterAccessCase.cpp
Source/JavaScriptCore/bytecode/InstanceOfAccessCase.cpp
Source/JavaScriptCore/bytecode/IntrinsicGetterAccessCase.cpp
Source/JavaScriptCore/bytecode/ModuleNamespaceAccessCase.cpp
Source/JavaScriptCore/bytecode/ProxyableAccessCase.cpp
Source/WTF/ChangeLog
Source/WTF/wtf/MetaAllocator.cpp
Source/WTF/wtf/text/StringConcatenate.h

index e52c7ec..d1018cd 100644 (file)
@@ -1,3 +1,29 @@
+2019-04-01  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Stop trying to support building JSC with clang 3.8
+        https://bugs.webkit.org/show_bug.cgi?id=195947
+        <rdar://problem/49069219>
+
+        Reviewed by Darin Adler.
+
+        It seems WebKit hasn't built with clang 3.8 in a while, no devs are using this compiler, we
+        don't know how much effort it would be to make JSC work again, and it's making the code
+        worse. Remove my hacks to support clang 3.8 from JSC.
+
+        * bindings/ScriptValue.cpp:
+        (Inspector::jsToInspectorValue):
+        * bytecode/GetterSetterAccessCase.cpp:
+        (JSC::GetterSetterAccessCase::create):
+        (JSC::GetterSetterAccessCase::clone const):
+        * bytecode/InstanceOfAccessCase.cpp:
+        (JSC::InstanceOfAccessCase::clone const):
+        * bytecode/IntrinsicGetterAccessCase.cpp:
+        (JSC::IntrinsicGetterAccessCase::clone const):
+        * bytecode/ModuleNamespaceAccessCase.cpp:
+        (JSC::ModuleNamespaceAccessCase::clone const):
+        * bytecode/ProxyableAccessCase.cpp:
+        (JSC::ProxyableAccessCase::clone const):
+
 2019-03-31  Yusuke Suzuki  <ysuzuki@apple.com>
 
         [JSC] Butterfly allocation from LargeAllocation should try "realloc" behavior if collector thread is not active
index 7a31728..7078aa7 100644 (file)
@@ -74,7 +74,7 @@ static RefPtr<JSON::Value> jsToInspectorValue(ExecState& scriptState, JSValue va
                     return nullptr;
                 inspectorArray->pushValue(WTFMove(elementValue));
             }
-            return RefPtr<JSON::Value> { WTFMove(inspectorArray) };
+            return inspectorArray;
         }
         VM& vm = scriptState.vm();
         auto inspectorObject = JSON::Object::create();
@@ -87,7 +87,7 @@ static RefPtr<JSON::Value> jsToInspectorValue(ExecState& scriptState, JSValue va
                 return nullptr;
             inspectorObject->setValue(name.string(), WTFMove(inspectorValue));
         }
-        return RefPtr<JSON::Value> { WTFMove(inspectorObject) };
+        return inspectorObject;
     }
 
     ASSERT_NOT_REACHED();
index e59c5a8..c9ed0aa 100644 (file)
@@ -66,7 +66,7 @@ std::unique_ptr<AccessCase> GetterSetterAccessCase::create(
     std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(vm, owner, type, offset, structure, conditionSet, viaProxy, additionalSet, customSlotBase, WTFMove(prototypeAccessChain)));
     result->m_domAttribute = domAttribute;
     result->m_customAccessor = customGetter ? FunctionPtr<OperationPtrTag>(customGetter) : nullptr;
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 
 std::unique_ptr<AccessCase> GetterSetterAccessCase::create(VM& vm, JSCell* owner, AccessType type, Structure* structure, PropertyOffset offset,
@@ -76,7 +76,7 @@ std::unique_ptr<AccessCase> GetterSetterAccessCase::create(VM& vm, JSCell* owner
     ASSERT(type == Setter || type == CustomValueSetter || type == CustomAccessorSetter);
     std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(vm, owner, type, offset, structure, conditionSet, false, nullptr, customSlotBase, WTFMove(prototypeAccessChain)));
     result->m_customAccessor = customSetter ? FunctionPtr<OperationPtrTag>(customSetter) : nullptr;
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 
 
@@ -97,7 +97,7 @@ std::unique_ptr<AccessCase> GetterSetterAccessCase::clone() const
 {
     std::unique_ptr<GetterSetterAccessCase> result(new GetterSetterAccessCase(*this));
     result->resetState();
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 
 bool GetterSetterAccessCase::hasAlternateBase() const
index 7cd2707..cfd33a0 100644 (file)
@@ -47,7 +47,7 @@ std::unique_ptr<AccessCase> InstanceOfAccessCase::clone() const
 {
     std::unique_ptr<InstanceOfAccessCase> result(new InstanceOfAccessCase(*this));
     result->resetState();
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 
 InstanceOfAccessCase::~InstanceOfAccessCase()
index 74e88a7..152941f 100644 (file)
@@ -51,7 +51,7 @@ std::unique_ptr<AccessCase> IntrinsicGetterAccessCase::clone() const
 {
     std::unique_ptr<IntrinsicGetterAccessCase> result(new IntrinsicGetterAccessCase(*this));
     result->resetState();
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 
 } // namespace JSC
index 756d195..b647fa5 100644 (file)
@@ -58,7 +58,7 @@ std::unique_ptr<AccessCase> ModuleNamespaceAccessCase::clone() const
 {
     std::unique_ptr<ModuleNamespaceAccessCase> result(new ModuleNamespaceAccessCase(*this));
     result->resetState();
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 
 void ModuleNamespaceAccessCase::emit(AccessGenerationState& state, MacroAssembler::JumpList& fallThrough)
index 6c1c546..8a3ef81 100644 (file)
@@ -52,7 +52,7 @@ std::unique_ptr<AccessCase> ProxyableAccessCase::clone() const
 {
     std::unique_ptr<ProxyableAccessCase> result(new ProxyableAccessCase(*this));
     result->resetState();
-    return std::unique_ptr<AccessCase> { WTFMove(result) };
+    return result;
 }
 
 void ProxyableAccessCase::dumpImpl(PrintStream& out, CommaPrinter& comma) const
index a5cad88..0dc3572 100644 (file)
@@ -1,3 +1,20 @@
+2019-04-01  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Stop trying to support building JSC with clang 3.8
+        https://bugs.webkit.org/show_bug.cgi?id=195947
+        <rdar://problem/49069219>
+
+        Reviewed by Darin Adler.
+
+        It seems WebKit hasn't built with clang 3.8 in a while, no devs are using this compiler, we
+        don't know how much effort it would be to make JSC work again, and it's making the code
+        worse. Remove my hacks to support clang 3.8 from WTF.
+
+        * wtf/MetaAllocator.cpp:
+        (WTF::MetaAllocator::allocate):
+        * wtf/text/StringConcatenate.h:
+        (WTF::tryMakeStringFromAdapters):
+
 2019-03-31  Yusuke Suzuki  <ysuzuki@apple.com>
 
         [JSC] Butterfly allocation from LargeAllocation should try "realloc" behavior if collector thread is not active
index 8b76dde..c3b6937 100644 (file)
@@ -194,7 +194,7 @@ RefPtr<MetaAllocatorHandle> MetaAllocator::allocate(size_t sizeInBytes, void* ow
     if (UNLIKELY(!!m_tracker))
         m_tracker->notify(handle.ptr());
 
-    return RefPtr<MetaAllocatorHandle> { WTFMove(handle) };
+    return handle;
 }
 
 MetaAllocator::Statistics MetaAllocator::currentStatistics()
index 1830561..c5d0201 100644 (file)
@@ -278,7 +278,7 @@ String tryMakeStringFromAdapters(StringTypeAdapter adapter, StringTypeAdapters .
 
         makeStringAccumulator(buffer, adapter, adapters...);
 
-        return String { WTFMove(resultImpl) };
+        return resultImpl;
     }
 
     UChar* buffer;
@@ -288,7 +288,7 @@ String tryMakeStringFromAdapters(StringTypeAdapter adapter, StringTypeAdapters .
 
     makeStringAccumulator(buffer, adapter, adapters...);
 
-    return String { WTFMove(resultImpl) };
+    return resultImpl;
 }
 
 template<typename... StringTypes>