Review page is super flakey now
authorojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Dec 2012 02:30:17 +0000 (02:30 +0000)
committerojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Dec 2012 02:30:17 +0000 (02:30 +0000)
https://bugs.webkit.org/show_bug.cgi?id=104331

Committing without review since this is breaking the code review tool.

remove is only shipping in Chromium. Use jQuery's remove instead.

* PrettyPatch/PrettyPatch.rb:
* code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/bugs.webkit.org/ChangeLog
Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
Websites/bugs.webkit.org/code-review.js

index 8c15ead..f7db8e6 100644 (file)
@@ -1,3 +1,15 @@
+2012-12-06  Ojan Vafai  <ojan@chromium.org>
+
+        Review page is super flakey now
+        https://bugs.webkit.org/show_bug.cgi?id=104331
+
+        Committing without review since this is breaking the code review tool.
+
+        remove is only shipping in Chromium. Use jQuery's remove instead.
+
+        * PrettyPatch/PrettyPatch.rb:
+        * code-review.js:
+
 2012-12-05  Ojan Vafai  <ojan@chromium.org>
 
         Make the strip line numbers link into a checkbox
index 9561f5c..45e794d 100644 (file)
@@ -506,7 +506,7 @@ div:focus {
 }
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=45"></script>
+<script src="code-review.js?version=46"></script>
 </head>
 EOF
 
index 7e0a13c..412fa19 100644 (file)
@@ -1160,7 +1160,7 @@ var CODE_REVIEW_UNITTEST;
 
     classesToRemove.forEach(function(className) {
       forEachNode(fragment.querySelectorAll('.' + className), function(node) {
-        node.remove();
+        $(node).remove();
       });
     });
 
@@ -1188,7 +1188,7 @@ var CODE_REVIEW_UNITTEST;
     selection.selectAllChildren(container);
 
     setTimeout(function() {
-      container.remove();
+      $(container).remove();
       selection.removeAllRanges();
       selection.addRange(range);
     });