[chromium] Add missing OVERRIDE and virtual annotations in compositor
authorjamesr@google.com <jamesr@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 Aug 2012 23:56:50 +0000 (23:56 +0000)
committerjamesr@google.com <jamesr@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 Aug 2012 23:56:50 +0000 (23:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=93438

Reviewed by Adrienne Walker.

As the title suggests.

* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
(BitmapCanvasLayerTextureUpdater):
* platform/graphics/chromium/ScrollbarLayerChromium.h:
(ScrollbarLayerChromium):
* platform/graphics/chromium/SolidColorLayerChromium.h:
(SolidColorLayerChromium):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
* platform/graphics/chromium/cc/CCFrameRateController.h:
(CCFrameRateController):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@125116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h
Source/WebCore/platform/graphics/chromium/ScrollbarLayerChromium.h
Source/WebCore/platform/graphics/chromium/SolidColorLayerChromium.h
Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.h
Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.h
Source/WebCore/platform/graphics/chromium/cc/CCScrollbarLayerImpl.h

index b7af857..1d1f69a 100644 (file)
@@ -1,3 +1,24 @@
+2012-08-08  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Add missing OVERRIDE and virtual annotations in compositor
+        https://bugs.webkit.org/show_bug.cgi?id=93438
+
+        Reviewed by Adrienne Walker.
+
+        As the title suggests.
+
+        * platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
+        (BitmapCanvasLayerTextureUpdater):
+        * platform/graphics/chromium/ScrollbarLayerChromium.h:
+        (ScrollbarLayerChromium):
+        * platform/graphics/chromium/SolidColorLayerChromium.h:
+        (SolidColorLayerChromium):
+        * platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
+        * platform/graphics/chromium/cc/CCFrameRateController.h:
+        (CCFrameRateController):
+        * platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
+        (CCScrollbarLayerImpl):
+
 2012-08-08  Eric Penner  <epenner@google.com>
 
         [chromium] Refactor tile flags.
index a2e6d45..8450e1f 100644 (file)
@@ -58,8 +58,8 @@ public:
     static PassRefPtr<BitmapCanvasLayerTextureUpdater> create(PassOwnPtr<LayerPainterChromium>);
     virtual ~BitmapCanvasLayerTextureUpdater();
 
-    virtual PassOwnPtr<LayerTextureUpdater::Texture> createTexture(CCPrioritizedTextureManager*);
-    virtual SampledTexelFormat sampledTexelFormat(GC3Denum textureFormat);
+    virtual PassOwnPtr<LayerTextureUpdater::Texture> createTexture(CCPrioritizedTextureManager*) OVERRIDE;
+    virtual SampledTexelFormat sampledTexelFormat(GC3Denum textureFormat) OVERRIDE;
     virtual void prepareToUpdate(const IntRect& contentRect, const IntSize& tileSize, float contentsWidthScale, float contentsHeightScale, IntRect& resultingOpaqueRect, CCRenderingStats&) OVERRIDE;
     void updateTextureRect(CCResourceProvider*, CCPrioritizedTexture*, const IntRect& sourceRect, const IntRect& destRect);
 
index 0eb053d..115fb66 100644 (file)
@@ -42,7 +42,7 @@ class CCTextureUpdateQueue;
 
 class ScrollbarLayerChromium : public LayerChromium {
 public:
-    virtual PassOwnPtr<CCLayerImpl> createCCLayerImpl();
+    virtual PassOwnPtr<CCLayerImpl> createCCLayerImpl() OVERRIDE;
     static PassRefPtr<ScrollbarLayerChromium> create(PassOwnPtr<WebKit::WebScrollbar>, WebKit::WebScrollbarThemePainter, PassOwnPtr<WebKit::WebScrollbarThemeGeometry>, int scrollLayerId);
 
     // LayerChromium interface
@@ -54,7 +54,7 @@ public:
     int scrollLayerId() const { return m_scrollLayerId; }
     void setScrollLayerId(int id) { m_scrollLayerId = id; }
 
-    virtual ScrollbarLayerChromium* toScrollbarLayerChromium() { return this; }
+    virtual ScrollbarLayerChromium* toScrollbarLayerChromium() OVERRIDE { return this; }
 
 protected:
     ScrollbarLayerChromium(PassOwnPtr<WebKit::WebScrollbar>, WebKit::WebScrollbarThemePainter, PassOwnPtr<WebKit::WebScrollbarThemeGeometry>, int scrollLayerId);
index 2496c7f..4a64e55 100644 (file)
@@ -36,7 +36,7 @@ namespace WebCore {
 // setBackgroundColor() on the base class.
 class SolidColorLayerChromium : public LayerChromium {
 public:
-    virtual PassOwnPtr<CCLayerImpl> createCCLayerImpl();
+    virtual PassOwnPtr<CCLayerImpl> createCCLayerImpl() OVERRIDE;
     static PassRefPtr<SolidColorLayerChromium> create();
 
     virtual ~SolidColorLayerChromium();
index 3ed96aa..61f637a 100644 (file)
@@ -44,6 +44,7 @@ public:
 
     virtual void setClient(CCTimeSourceClient* client) OVERRIDE { m_client = client; }
 
+    // CCTimeSource implementation
     virtual void setTimebaseAndInterval(double timebase, double intervalSeconds) OVERRIDE;
 
     virtual void setActive(bool) OVERRIDE;
@@ -51,8 +52,8 @@ public:
 
     // Get the last and next tick times.
     // If not active, nextTickTime will return 0.
-    virtual double lastTickTime();
-    virtual double nextTickTime();
+    virtual double lastTickTime() OVERRIDE;
+    virtual double nextTickTime() OVERRIDE;
 
     // CCTimerClient implementation.
     virtual void onTimerFired() OVERRIDE;
index c1719b0..69c9037 100644 (file)
@@ -52,7 +52,7 @@ public:
     explicit CCFrameRateController(PassRefPtr<CCTimeSource>);
     // Alternate form of CCFrameRateController with unthrottled frame-rate.
     explicit CCFrameRateController(CCThread*);
-    ~CCFrameRateController();
+    virtual ~CCFrameRateController();
 
     void setClient(CCFrameRateControllerClient* client) { m_client = client; }
 
index 24cb0d1..5b8dac2 100644 (file)
@@ -63,7 +63,7 @@ public:
 
     virtual void appendQuads(CCQuadSink&, const CCSharedQuadState*, bool& hadMissingTiles) OVERRIDE;
 
-    void didLoseContext() OVERRIDE;
+    virtual void didLoseContext() OVERRIDE;
 
 protected:
     explicit CCScrollbarLayerImpl(int id);