[AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Sep 2013 09:39:34 +0000 (09:39 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Sep 2013 09:39:34 +0000 (09:39 +0000)
https://bugs.webkit.org/show_bug.cgi?id=121023

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-09
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Test: accessibility/progressbar.html

ProgressBar element should support ATK_VALUE interface.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(getInterfaceMaskFromObject):

Tools:

Added mappings to ATK's ProgressBar element.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(roleToString):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::roleToString):

LayoutTests:

Sharing progressbar.html specific mac test with efl and gtk.

* accessibility/progressbar-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/progressbar-expected.txt.
* accessibility/progressbar.html: Renamed from LayoutTests/platform/mac/accessibility/progressbar.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/accessibility/progressbar-expected.txt [moved from LayoutTests/platform/mac/accessibility/progressbar-expected.txt with 100% similarity]
LayoutTests/accessibility/progressbar.html [moved from LayoutTests/platform/mac/accessibility/progressbar.html with 93% similarity]
Source/WebCore/ChangeLog
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
Tools/ChangeLog
Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

index 2a68884..ed89170 100644 (file)
@@ -1,3 +1,15 @@
+2013-09-09  Krzysztof Czech  <k.czech@samsung.com>
+
+        [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
+        https://bugs.webkit.org/show_bug.cgi?id=121023
+
+        Reviewed by Mario Sanchez Prada.
+
+        Sharing progressbar.html specific mac test with efl and gtk.
+
+        * accessibility/progressbar-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/progressbar-expected.txt.
+        * accessibility/progressbar.html: Renamed from LayoutTests/platform/mac/accessibility/progressbar.html.
+
 2013-09-08  Gurpreet Kaur  <k.gurpreet@samsung.com>
 
         defining line height affects height of text box
@@ -1,7 +1,7 @@
 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
 <html>
 <head>
-<script src="../../../resources/js-test-pre.js"></script>
+<script src="../resources/js-test-pre.js"></script>
 </head>
 <body id="body">
 
@@ -49,6 +49,6 @@
 
 </script>
 
-<script src="../../../resources/js-test-post.js"></script>
+<script src="../resources/js-test-post.js"></script>
 </body>
 </html>
index 558a378..322d685 100644 (file)
@@ -1,3 +1,17 @@
+2013-09-09  Krzysztof Czech  <k.czech@samsung.com>
+
+        [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
+        https://bugs.webkit.org/show_bug.cgi?id=121023
+
+        Reviewed by Mario Sanchez Prada.
+
+        Test: accessibility/progressbar.html
+
+        ProgressBar element should support ATK_VALUE interface.
+
+        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+        (getInterfaceMaskFromObject):
+
 2013-09-09  Claudio Saavedra  <csaavedra@igalia.com>
 
         [GTK]  ghost cursor when mouse hovers over an image file in a tab
index b38b229..3e233df 100644 (file)
@@ -1033,7 +1033,7 @@ static guint16 getInterfaceMaskFromObject(AccessibilityObject* coreObject)
         interfaceMask |= 1 << WAI_DOCUMENT;
 
     // Value
-    if (role == SliderRole || role == SpinButtonRole || role == ScrollBarRole)
+    if (role == SliderRole || role == SpinButtonRole || role == ScrollBarRole || role == ProgressIndicatorRole)
         interfaceMask |= 1 << WAI_VALUE;
 
 #if ENABLE(INPUT_TYPE_COLOR)
index b238126..4401f56 100644 (file)
@@ -1,3 +1,17 @@
+2013-09-09  Krzysztof Czech  <k.czech@samsung.com>
+
+        [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
+        https://bugs.webkit.org/show_bug.cgi?id=121023
+
+        Reviewed by Mario Sanchez Prada.
+
+        Added mappings to ATK's ProgressBar element.
+
+        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+        (roleToString):
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+        (WTR::roleToString):
+
 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
 
         run-jsc-stress-tests should be more paranoid about calling make
index 2472680..747e498 100644 (file)
@@ -152,6 +152,8 @@ static inline const char* roleToString(AtkRole role)
         return "AXParagraph";
     case ATK_ROLE_PASSWORD_TEXT:
         return "AXPasswordField";
+    case ATK_ROLE_PROGRESS_BAR:
+        return "AXProgressIndicator";
     case ATK_ROLE_PUSH_BUTTON:
         return "AXButton";
     case ATK_ROLE_RADIO_BUTTON:
index a9e80ad..ddab8f4 100644 (file)
@@ -241,6 +241,8 @@ static const gchar* roleToString(AtkRole role)
         return "AXParagraph";
     case ATK_ROLE_PASSWORD_TEXT:
         return "AXPasswordField";
+    case ATK_ROLE_PROGRESS_BAR:
+        return "AXProgressIndicator";
     case ATK_ROLE_PUSH_BUTTON:
         return "AXButton";
     case ATK_ROLE_RADIO_BUTTON: