Chromium needs support for border radius clipping
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 Oct 2012 02:17:34 +0000 (02:17 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 Oct 2012 02:17:34 +0000 (02:17 +0000)
https://bugs.webkit.org/show_bug.cgi?id=69866

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-10-03
Reviewed by Stephen White.

Source/WebCore:

Changes to make this suitably efficient have already landed upstream in skia:
http://code.google.com/p/skia/source/detail?r=2924

Covered by existing tests.

* rendering/RenderLayer.cpp:

LayoutTests:

* platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png:
* platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png:
* platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png:
* platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-linux/media/audio-controls-rendering-expected.png:
* platform/chromium-linux/media/audio-repaint-expected.png:
* platform/chromium-linux/media/controls-after-reload-expected.png:
* platform/chromium-linux/media/controls-strict-expected.png:
* platform/chromium-linux/media/controls-styling-expected.png:
* platform/chromium-linux/media/controls-styling-strict-expected.png:
* platform/chromium-linux/media/controls-without-preload-expected.png:
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-linux/media/video-display-toggle-expected.png:
* platform/chromium-linux/media/video-no-audio-expected.png:
* platform/chromium-linux/media/video-playing-and-pause-expected.png:
* platform/chromium-linux/media/video-zoom-controls-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@130355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

22 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png
LayoutTests/platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png
LayoutTests/platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png
LayoutTests/platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png
LayoutTests/platform/chromium-linux/media/audio-controls-rendering-expected.png
LayoutTests/platform/chromium-linux/media/audio-repaint-expected.png
LayoutTests/platform/chromium-linux/media/controls-after-reload-expected.png
LayoutTests/platform/chromium-linux/media/controls-strict-expected.png
LayoutTests/platform/chromium-linux/media/controls-styling-expected.png
LayoutTests/platform/chromium-linux/media/controls-styling-strict-expected.png
LayoutTests/platform/chromium-linux/media/controls-without-preload-expected.png
LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png
LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png
LayoutTests/platform/chromium-linux/media/video-controls-rendering-expected.png
LayoutTests/platform/chromium-linux/media/video-display-toggle-expected.png
LayoutTests/platform/chromium-linux/media/video-no-audio-expected.png
LayoutTests/platform/chromium-linux/media/video-playing-and-pause-expected.png
LayoutTests/platform/chromium-linux/media/video-zoom-controls-expected.png
LayoutTests/platform/chromium/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderLayer.cpp

index 1e4250f..2d49700 100644 (file)
@@ -1,3 +1,30 @@
+2012-10-03  Douglas Stockwell  <dstockwell@chromium.org>
+
+        Chromium needs support for border radius clipping
+        https://bugs.webkit.org/show_bug.cgi?id=69866
+
+        Reviewed by Stephen White.
+
+        * platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png:
+        * platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png:
+        * platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png:
+        * platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
+        * platform/chromium-linux/media/audio-controls-rendering-expected.png:
+        * platform/chromium-linux/media/audio-repaint-expected.png:
+        * platform/chromium-linux/media/controls-after-reload-expected.png:
+        * platform/chromium-linux/media/controls-strict-expected.png:
+        * platform/chromium-linux/media/controls-styling-expected.png:
+        * platform/chromium-linux/media/controls-styling-strict-expected.png:
+        * platform/chromium-linux/media/controls-without-preload-expected.png:
+        * platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
+        * platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
+        * platform/chromium-linux/media/video-controls-rendering-expected.png:
+        * platform/chromium-linux/media/video-display-toggle-expected.png:
+        * platform/chromium-linux/media/video-no-audio-expected.png:
+        * platform/chromium-linux/media/video-playing-and-pause-expected.png:
+        * platform/chromium-linux/media/video-zoom-controls-expected.png:
+        * platform/chromium/TestExpectations:
+
 2012-10-03  Tony Chang  <tony@chromium.org>
 
         Unreviewed, remove 2 tests that were moved in http://trac.webkit.org/changeset/130150.
index edf4054..518ce0b 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png and b/LayoutTests/platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png differ
index 0eb0999..0ad4955 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png and b/LayoutTests/platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png differ
index ff4803e..acd62e1 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png and b/LayoutTests/platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png differ
index 3223faa..b2f9f2e 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png and b/LayoutTests/platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png differ
index fd4c145..7fc473c 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/audio-controls-rendering-expected.png and b/LayoutTests/platform/chromium-linux/media/audio-controls-rendering-expected.png differ
index bf877ef..a7426fd 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/audio-repaint-expected.png and b/LayoutTests/platform/chromium-linux/media/audio-repaint-expected.png differ
index 30a563d..46658b7 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/controls-after-reload-expected.png and b/LayoutTests/platform/chromium-linux/media/controls-after-reload-expected.png differ
index 7046c69..872f670 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/controls-strict-expected.png and b/LayoutTests/platform/chromium-linux/media/controls-strict-expected.png differ
index 22a133e..340e163 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/controls-styling-expected.png and b/LayoutTests/platform/chromium-linux/media/controls-styling-expected.png differ
index 7fb15be..dffdee8 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/controls-styling-strict-expected.png and b/LayoutTests/platform/chromium-linux/media/controls-styling-strict-expected.png differ
index 6cad2b2..91c970a 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/controls-without-preload-expected.png and b/LayoutTests/platform/chromium-linux/media/controls-without-preload-expected.png differ
index 74562be..747787e 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png and b/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png differ
index c6bfd03..4cbe9da 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png and b/LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png differ
index e025000..0bfff0b 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/video-controls-rendering-expected.png and b/LayoutTests/platform/chromium-linux/media/video-controls-rendering-expected.png differ
index 9c289e4..4d2724a 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/video-display-toggle-expected.png and b/LayoutTests/platform/chromium-linux/media/video-display-toggle-expected.png differ
index b1baa41..a38b710 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/video-no-audio-expected.png and b/LayoutTests/platform/chromium-linux/media/video-no-audio-expected.png differ
index 1f87e5e..e4f6b9d 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/video-playing-and-pause-expected.png and b/LayoutTests/platform/chromium-linux/media/video-playing-and-pause-expected.png differ
index fdbc812..afdf7c4 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/media/video-zoom-controls-expected.png and b/LayoutTests/platform/chromium-linux/media/video-zoom-controls-expected.png differ
index a4e86d1..5dd3538 100644 (file)
@@ -2523,12 +2523,27 @@ webkit.org/b/67915 [ Android Linux Win ] fast/borders/borderRadiusDashed06.html
 
 webkit.org/b/95365 fast/loader/reload-zero-byte-plugin.html
 
-# Performance issues with border radius clipping on Chromium not yet resolved
-crbug.com/97716 fast/clip/overflow-border-radius-composited.html [ ImageOnlyFailure ]
-# Consistently failing as of about r95590
-crbug.com/97716 fast/clip/overflow-border-radius-fixed-position.html [ ImageOnlyFailure ]
-crbug.com/97716 fast/clip/overflow-border-radius-transformed.html [ ImageOnlyFailure ]
-crbug.com/97716 fast/clip/overflow-border-radius-combinations.html [ ImageOnlyFailure ]
+webkit.org/b/68196 fast/clip/overflow-border-radius-composited.html [ ImageOnlyFailure ]
+
+# Needs rebaseline
+webkit.org/b/69866 [ Android Mac Win ] fast/clip/overflow-border-radius-combinations.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] fast/clip/overflow-border-radius-fixed-position.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] fast/clip/overflow-border-radius-transformed.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] http/tests/media/video-buffered-range-contains-currentTime.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/audio-controls-rendering.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/audio-repaint.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/controls-after-reload.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/controls-strict.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/controls-styling-strict.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/controls-styling.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/controls-without-preload.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/track/track-cue-rendering-horizontal.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/track/track-cue-rendering-vertical.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/video-controls-rendering.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/video-display-toggle.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/video-no-audio.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/video-playing-and-pause.html [ ImageOnlyFailure ]
+webkit.org/b/69866 [ Android Mac Win ] media/video-zoom-controls.html [ ImageOnlyFailure ]
 
 # Caused by r92618
 webkit.org/b/65874 fast/js/preventExtensions.html [ Failure ]
index 9662ad1..7a4eba7 100644 (file)
@@ -1,3 +1,17 @@
+2012-10-03  Douglas Stockwell  <dstockwell@chromium.org>
+
+        Chromium needs support for border radius clipping
+        https://bugs.webkit.org/show_bug.cgi?id=69866
+
+        Reviewed by Stephen White.
+
+        Changes to make this suitably efficient have already landed upstream in skia:
+        http://code.google.com/p/skia/source/detail?r=2924
+
+        Covered by existing tests.
+
+        * rendering/RenderLayer.cpp:
+
 2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
 
         Simplify attribute access in Element::computeInheritedLanguage
index a2600a5..76c45d2 100644 (file)
 #include "SVGNames.h"
 #endif
 
-#if PLATFORM(CHROMIUM) || PLATFORM(BLACKBERRY)
-// FIXME: border radius clipping triggers too-slow path on Chromium
-// https://bugs.webkit.org/show_bug.cgi?id=69866
+#if PLATFORM(BLACKBERRY)
 #define DISABLE_ROUNDED_CORNER_CLIPPING
 #endif