there is no vp8 support in youtube.com/html5 page with libwebkit2gtk 2.24 (MSE enabled)
authorphiln@webkit.org <philn@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Apr 2019 13:46:01 +0000 (13:46 +0000)
committerphiln@webkit.org <philn@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Apr 2019 13:46:01 +0000 (13:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196615

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Add vp8.0 and vp9.0 in supported mime-types if the corresponding video decoders are found.

No new tests, existing web-platform-tests cover this change.

* platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::initialize):

LayoutTests:

Update WPE baselines and add/unskip the
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html test in GTK.

* platform/gtk/TestExpectations:
* platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Copied from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt.
* platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt [new file with mode: 0644]
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp

index a8f1815..884a5ba 100644 (file)
@@ -1,3 +1,17 @@
+2019-04-10  Philippe Normand  <pnormand@igalia.com>
+
+        there is no vp8 support in youtube.com/html5 page with libwebkit2gtk 2.24 (MSE enabled)
+        https://bugs.webkit.org/show_bug.cgi?id=196615
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Update WPE baselines and add/unskip the
+        imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html test in GTK.
+
+        * platform/gtk/TestExpectations:
+        * platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Copied from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt.
+        * platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt:
+
 2019-04-10  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [ATK] Defer the emision of AtkObject::children-changed signal after layout is done
index 2ed65e7..0bba3c2 100644 (file)
@@ -3121,8 +3121,6 @@ webkit.org/b/148935 accessibility/scroll-to-make-visible-nested-2.html [ Failure
 webkit.org/b/148935 accessibility/scroll-to-make-visible-nested.html [ Failure ]
 webkit.org/b/148935 accessibility/scroll-to-make-visible-with-subfocus.html [ Failure ]
 
-webkit.org/b/148936 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType.html [ Failure ]
-
 webkit.org/b/149128 fast/text/control-characters [ ImageOnlyFailure ]
 
 # web-platform-tests XHR tests
diff --git a/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt b/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt
new file mode 100644 (file)
index 0000000..4047cab
--- /dev/null
@@ -0,0 +1,62 @@
+
+
+PASS utility code 
+PASS application/octet-stream not supported 
+PASS fictional formats and codecs not supported 
+PASS audio/mp4 (optional) 
+PASS audio/mp4; codecs="mp4a.40.2" (optional) 
+PASS audio/mp4 with bogus codec 
+PASS audio/mp4 with and without codecs 
+PASS audio/ogg (optional) 
+PASS audio/ogg; codecs="opus" (optional) 
+PASS audio/ogg; codecs="vorbis" (optional) 
+PASS audio/ogg with bogus codec 
+PASS audio/ogg with and without codecs 
+PASS audio/wav (optional) 
+PASS audio/wav; codecs="1" (optional) 
+PASS audio/wav with bogus codec 
+PASS audio/wav with and without codecs 
+PASS audio/webm (optional) 
+PASS audio/webm; codecs="opus" (optional) 
+PASS audio/webm; codecs="vorbis" (optional) 
+PASS audio/webm with bogus codec 
+PASS audio/webm with and without codecs 
+PASS video/3gpp (optional) 
+FAIL video/3gpp; codecs="samr" (optional) assert_equals: video/3gpp; codecs="samr" expected "probably" but got ""
+PASS video/3gpp; codecs="mp4v.20.8" (optional) 
+PASS video/3gpp codecs subset 
+PASS video/3gpp codecs order 
+PASS video/3gpp with bogus codec 
+PASS video/3gpp with and without codecs 
+PASS video/mp4 (optional) 
+PASS video/mp4; codecs="mp4a.40.2" (optional) 
+PASS video/mp4; codecs="avc1.42E01E" (optional) 
+PASS video/mp4; codecs="avc1.4D401E" (optional) 
+PASS video/mp4; codecs="avc1.58A01E" (optional) 
+PASS video/mp4; codecs="avc1.64001E" (optional) 
+PASS video/mp4; codecs="mp4v.20.8" (optional) 
+PASS video/mp4; codecs="mp4v.20.240" (optional) 
+PASS video/mp4 codecs subset 
+PASS video/mp4 codecs order 
+PASS video/mp4 with bogus codec 
+PASS video/mp4 with and without codecs 
+PASS video/ogg (optional) 
+PASS video/ogg; codecs="opus" (optional) 
+PASS video/ogg; codecs="vorbis" (optional) 
+PASS video/ogg; codecs="theora" (optional) 
+PASS video/ogg codecs subset 
+PASS video/ogg codecs order 
+PASS video/ogg with bogus codec 
+PASS video/ogg with and without codecs 
+PASS video/webm (optional) 
+PASS video/webm; codecs="opus" (optional) 
+PASS video/webm; codecs="vorbis" (optional) 
+PASS video/webm; codecs="vp8" (optional) 
+PASS video/webm; codecs="vp8.0" (optional) 
+PASS video/webm; codecs="vp9" (optional) 
+PASS video/webm; codecs="vp9.0" (optional) 
+PASS video/webm codecs subset 
+PASS video/webm codecs order 
+PASS video/webm with bogus codec 
+PASS video/webm with and without codecs 
+
index ba2933b..4047cab 100644 (file)
@@ -52,9 +52,9 @@ PASS video/webm (optional)
 PASS video/webm; codecs="opus" (optional) 
 PASS video/webm; codecs="vorbis" (optional) 
 PASS video/webm; codecs="vp8" (optional) 
-FAIL video/webm; codecs="vp8.0" (optional) assert_equals: video/webm; codecs="vp8.0" expected "probably" but got ""
+PASS video/webm; codecs="vp8.0" (optional) 
 PASS video/webm; codecs="vp9" (optional) 
-FAIL video/webm; codecs="vp9.0" (optional) assert_equals: video/webm; codecs="vp9.0" expected "probably" but got ""
+PASS video/webm; codecs="vp9.0" (optional) 
 PASS video/webm codecs subset 
 PASS video/webm codecs order 
 PASS video/webm with bogus codec 
index d7aeee8..66147c5 100644 (file)
@@ -1,5 +1,19 @@
 2019-04-10  Philippe Normand  <pnormand@igalia.com>
 
+        there is no vp8 support in youtube.com/html5 page with libwebkit2gtk 2.24 (MSE enabled)
+        https://bugs.webkit.org/show_bug.cgi?id=196615
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Add vp8.0 and vp9.0 in supported mime-types if the corresponding video decoders are found.
+
+        No new tests, existing web-platform-tests cover this change.
+
+        * platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
+        (WebCore::GStreamerRegistryScanner::initialize):
+
+2019-04-10  Philippe Normand  <pnormand@igalia.com>
+
         [GStreamer] Adaptive streaming playback broken with GStreamer < 1.12
         https://bugs.webkit.org/show_bug.cgi?id=196765
 
index 3cf0bc3..8802188 100644 (file)
@@ -168,10 +168,12 @@ void GStreamerRegistryScanner::initialize()
         if (vp8DecoderAvailable) {
             m_codecMap.add(AtomicString("vp8"), vp8DecoderAvailable.isUsingHardware);
             m_codecMap.add(AtomicString("x-vp8"), vp8DecoderAvailable.isUsingHardware);
+            m_codecMap.add(AtomicString("vp8.0"), vp8DecoderAvailable.isUsingHardware);
         }
         if (vp9DecoderAvailable) {
             m_codecMap.add(AtomicString("vp9"), vp9DecoderAvailable.isUsingHardware);
             m_codecMap.add(AtomicString("x-vp9"), vp9DecoderAvailable.isUsingHardware);
+            m_codecMap.add(AtomicString("vp9.0"), vp9DecoderAvailable.isUsingHardware);
         }
         if (opusSupported)
             m_mimeTypeSet.add(AtomicString("audio/webm"));