Update pip placard to "picture in picture"
authorjonlee@apple.com <jonlee@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Apr 2017 17:53:11 +0000 (17:53 +0000)
committerjonlee@apple.com <jonlee@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Apr 2017 17:53:11 +0000 (17:53 +0000)
https://bugs.webkit.org/show_bug.cgi?id=171036
rdar://problem/30201536

Reviewed by Antoine Quint.

Source/WebCore:

Updated media/modern-media-controls/pip-placard/pip-placard.html

Update the text shown with the picture in picture placard.

* English.lproj/mediaControlsLocalizedStrings.js:
* English.lproj/modern-media-controls-localized-strings.js:
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.updatePictureInPicturePlaceholder):
* Modules/modern-media-controls/controls/pip-placard.js:
(PiPPlacard):

LayoutTests:

* media/modern-media-controls/pip-placard/pip-placard-expected.txt: Updated expected results.
* media/modern-media-controls/pip-placard/pip-placard.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@215564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/media/modern-media-controls/pip-placard/pip-placard-expected.txt
LayoutTests/media/modern-media-controls/pip-placard/pip-placard.html
Source/WebCore/ChangeLog
Source/WebCore/English.lproj/mediaControlsLocalizedStrings.js
Source/WebCore/English.lproj/modern-media-controls-localized-strings.js
Source/WebCore/Modules/mediacontrols/mediaControlsApple.js
Source/WebCore/Modules/modern-media-controls/controls/pip-placard.js

index da7bc48..cd992ca 100644 (file)
@@ -1,3 +1,14 @@
+2017-04-20  Jon Lee  <jonlee@apple.com>
+
+        Update pip placard to "picture in picture"
+        https://bugs.webkit.org/show_bug.cgi?id=171036
+        rdar://problem/30201536
+
+        Reviewed by Antoine Quint.
+
+        * media/modern-media-controls/pip-placard/pip-placard-expected.txt: Updated expected results.
+        * media/modern-media-controls/pip-placard/pip-placard.html:
+
 2017-04-20  Ryan Haddad  <ryanhaddad@apple.com>
 
         Mark two crypto/subtle/ecdsa LayoutTests as flaky.
index f087df9..b7d2e34 100644 (file)
@@ -5,7 +5,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 Placard with all parameters
 PASS placard.children[0].children[0].iconName is Icons.PiPPlacard
-PASS placard.children[0].children[1].element.innerText is "This video is playing in Picture in Picture"
+PASS placard.children[0].children[1].element.innerText is "This video is playing in picture in picture."
 PASS successfullyParsed is true
 
 TEST COMPLETE
index 0f63814..65a28bf 100644 (file)
@@ -9,7 +9,7 @@ debug("Placard with all parameters");
 const placard = new PiPPlacard({ layoutTraits: LayoutTraits.macOS });
 
 shouldBe("placard.children[0].children[0].iconName", "Icons.PiPPlacard");
-shouldBeEqualToString("placard.children[0].children[1].element.innerText", "This video is playing in Picture in Picture");
+shouldBeEqualToString("placard.children[0].children[1].element.innerText", "This video is playing in picture in picture.");
 
 </script>
 <script src="../../../resources/js-test-post.js"></script>
index 8c53d5f..0b56365 100644 (file)
@@ -1,3 +1,22 @@
+2017-04-20  Jon Lee  <jonlee@apple.com>
+
+        Update pip placard to "picture in picture"
+        https://bugs.webkit.org/show_bug.cgi?id=171036
+        rdar://problem/30201536
+
+        Reviewed by Antoine Quint.
+
+        Updated media/modern-media-controls/pip-placard/pip-placard.html
+
+        Update the text shown with the picture in picture placard.
+
+        * English.lproj/mediaControlsLocalizedStrings.js:
+        * English.lproj/modern-media-controls-localized-strings.js:
+        * Modules/mediacontrols/mediaControlsApple.js:
+        (Controller.prototype.updatePictureInPicturePlaceholder):
+        * Modules/modern-media-controls/controls/pip-placard.js:
+        (PiPPlacard):
+
 2017-04-20  Youenn Fablet  <youenn@apple.com>
 
         RTCPeerConnection is stopping its backend twice sometimes
index 1396898..bc416bd 100644 (file)
@@ -38,7 +38,7 @@ var UIStringTable = {
     'Start Playback': 'Start Playback',
     'Subtitles': 'Subtitles',
     'Suspended': 'Suspended',
-    'This video is playing in Picture in Picture': 'This video is playing in Picture in Picture',
+    'This video is playing in picture in picture.': 'This video is playing in picture in picture.',
     'Unmute': 'Unmute',
     'Video Playback': 'Video Playback',
     'Video Playback Placeholder': 'Video Playback Placeholder',
index 7cf2a45..7398913 100644 (file)
@@ -20,7 +20,7 @@ const UIStrings = {
     "Scale to Fit": "Scale to Fit",
     "Subtitles": "Subtitles",
     "Start": "Start",
-    "This video is playing in Picture in Picture": "This video is playing in Picture in Picture",
+    "This video is playing in picture in picture.": "This video is playing in picture in picture.",
     "This video is playing on your Apple TV": "This video is playing on your Apple TV",
     "Unmute": "Unmute",
     "Volume": "Volume",
index d189373..77697c0 100644 (file)
@@ -936,7 +936,7 @@ Controller.prototype = {
                 this.controls.inlinePlaybackPlaceholder.classList.add(this.ClassNames.pictureInPicture);
                 this.showInlinePlaybackPlaceholderWhenSafe();
 
-                this.controls.inlinePlaybackPlaceholderTextTop.innerText = this.UIString('This video is playing in Picture in Picture');
+                this.controls.inlinePlaybackPlaceholderTextTop.innerText = this.UIString('This video is playing in picture in picture.');
                 this.controls.inlinePlaybackPlaceholderTextTop.classList.add(this.ClassNames.pictureInPicture);
                 this.controls.inlinePlaybackPlaceholderTextBottom.innerText = "";
                 this.controls.inlinePlaybackPlaceholderTextBottom.classList.add(this.ClassNames.pictureInPicture);
index 1ee8bb8..9ae3902 100644 (file)
@@ -30,7 +30,7 @@ class PiPPlacard extends Placard
     {
         super({
             iconName: Icons.PiPPlacard,
-            description: UIString("This video is playing in Picture in Picture"),
+            description: UIString("This video is playing in picture in picture."),
             layoutDelegate
         });
     }