Reviewed by John
authorkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Dec 2004 17:31:30 +0000 (17:31 +0000)
committerkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Dec 2004 17:31:30 +0000 (17:31 +0000)
        Terminology change in execCommand command identifiers. Specifically, the name of
        "InsertNewline" command has been changed to "InsertLineBreak". This matches the
        terminology used by AppKit. It is also more accurate, since the insertion of a
        "br" element is what the command does. The inspiration for this change is so the
        -insertNewline AppKit method can be mapped to insert a new "div" element in
        a document and avoid ambiguity with what the javascript editing command does.

        * khtml/editing/jsediting.cpp
        * layout-tests/editing/deleting/delete-tab-004.html
        * layout-tests/editing/editing.js
        * layout-tests/editing/inserting/insert-3654864-fix.html
        * layout-tests/editing/inserting/insert-3659587-fix.html
        * layout-tests/editing/inserting/insert-3775316-fix.html
        * layout-tests/editing/inserting/insert-3800346-fix.html
        * layout-tests/editing/inserting/insert-br-001.html
        * layout-tests/editing/inserting/insert-br-002.html
        * layout-tests/editing/inserting/insert-br-003.html
        * layout-tests/editing/inserting/insert-br-004.html
        * layout-tests/editing/inserting/insert-br-005.html
        * layout-tests/editing/inserting/insert-br-006.html
        * layout-tests/editing/inserting/insert-br-007.html
        * layout-tests/editing/inserting/insert-br-008.html
        * layout-tests/editing/inserting/insert-tab-004.html
        * layout-tests/editing/inserting/insert-text-with-newlines.html
        * layout-tests/editing/pasteboard/paste-text-010.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 files changed:
LayoutTests/editing/deleting/delete-tab-004.html
LayoutTests/editing/editing.js
LayoutTests/editing/inserting/insert-3654864-fix.html
LayoutTests/editing/inserting/insert-3659587-fix.html
LayoutTests/editing/inserting/insert-3775316-fix.html
LayoutTests/editing/inserting/insert-3800346-fix.html
LayoutTests/editing/inserting/insert-br-001.html
LayoutTests/editing/inserting/insert-br-002.html
LayoutTests/editing/inserting/insert-br-003.html
LayoutTests/editing/inserting/insert-br-004.html
LayoutTests/editing/inserting/insert-br-005.html
LayoutTests/editing/inserting/insert-br-006.html
LayoutTests/editing/inserting/insert-br-007.html
LayoutTests/editing/inserting/insert-br-008.html
LayoutTests/editing/inserting/insert-tab-004.html
LayoutTests/editing/inserting/insert-text-with-newlines.html
LayoutTests/editing/pasteboard/paste-text-010.html
WebCore/ChangeLog-2005-08-23
WebCore/khtml/editing/jsediting.cpp

index 916de4d..3e95324 100644 (file)
@@ -13,7 +13,7 @@
 <script>
 
 function editingTest() {
-    insertNewlineCommand();
+    insertLineBreakCommand();
     typeCharacterCommand('\t');
     typeCharacterCommand('\t');
     for (i = 0; i < 4; i++)
index ee5c08e..468e8c6 100644 (file)
@@ -269,16 +269,16 @@ function justifyRightCommand() {
 
 //-------------------------------------------------------------------------------------------------------
 
-function execInsertNewlineCommand() {
-    document.execCommand("InsertNewline");
+function execInsertLineBreakCommand() {
+    document.execCommand("InsertLineBreak");
 }
-function insertNewlineCommand() {
+function insertLineBreakCommand() {
     if (commandDelay > 0) {
-        window.setTimeout(execInsertNewlineCommand, commandCount * commandDelay);
+        window.setTimeout(execInsertLineBreakCommand, commandCount * commandDelay);
         commandCount++;
     }
     else {
-        execInsertNewlineCommand();
+        execInsertLineBreakCommand();
     }
 }
 
index 6431ca4..a6841b0 100644 (file)
@@ -14,7 +14,7 @@
 
 function editingTest() {
     selectAllCommand();
-    insertNewlineCommand();
+    insertLineBreakCommand();
     for (i = 0; i < 3; i++) {
         typeCharacterCommand();
     }
index 21f4844..b4084e6 100644 (file)
@@ -22,7 +22,7 @@ function editingTest() {
     for (i = 0; i < 3; i++) {
         typeCharacterCommand();
     }
-    insertNewlineCommand();
+    insertLineBreakCommand();
     for (i = 0; i < 3; i++) {
         typeCharacterCommand();
     }
index 91135f8..b6345d3 100644 (file)
 
 function editingTest() {
     moveSelectionForwardByCharacterCommand();
-    insertNewlineCommand();
+    insertLineBreakCommand();
     typeCharacterCommand();
     selectAllCommand();
     deleteCommand();
     typeCharacterCommand();
-    insertNewlineCommand();
+    insertLineBreakCommand();
     typeCharacterCommand();
 }
 
index 782e8ca..2c562ae 100644 (file)
@@ -16,7 +16,7 @@ function editingTest() {
     for (i = 0; i < 15; i++)
         moveSelectionForwardByCharacterCommand();
     for (i = 0; i < 3; i++)
-        insertNewlineCommand();
+        insertLineBreakCommand();
 }
 
 </script>
index ba53c2c..bc6f8a1 100644 (file)
@@ -15,7 +15,7 @@
 function editingTest() {
     selectAllCommand();
     moveSelectionForwardByCharacterCommand();
-    insertNewlineCommand();
+    insertLineBreakCommand();
     typeCharacterCommand();
 }
 
index f5d2805..7d16c30 100644 (file)
@@ -15,7 +15,7 @@
 function editingTest() {
     for (i = 0; i < 4; i++)
         moveSelectionForwardByCharacterCommand();
-    insertNewlineCommand();
+    insertLineBreakCommand();
     typeCharacterCommand();
 }
 
index 3ea2358..1fed4ab 100644 (file)
@@ -15,7 +15,7 @@
 function editingTest() {
     for (i = 0; i < 4; i++)
         moveSelectionForwardByCharacterCommand();
-    insertNewlineCommand();
+    insertLineBreakCommand();
     typeCharacterCommand();
 }
 
index 951f545..de2fd32 100644 (file)
@@ -15,8 +15,8 @@
 function editingTest() {
     for (i = 0; i < 3; i++)
         moveSelectionForwardByCharacterCommand();
-    insertNewlineCommand();
-    insertNewlineCommand();
+    insertLineBreakCommand();
+    insertLineBreakCommand();
 }
 
 </script>
index 56d784f..b4ba3cd 100644 (file)
@@ -15,8 +15,8 @@
 function editingTest() {
     for (i = 0; i < 3; i++)
         moveSelectionForwardByCharacterCommand();
-    insertNewlineCommand();
-    insertNewlineCommand();
+    insertLineBreakCommand();
+    insertLineBreakCommand();
     typeCharacterCommand();
 }
 
index 9d6577e..d3d58c5 100644 (file)
@@ -13,7 +13,7 @@
 <script>
 
 function editingTest() {
-    insertNewlineCommand();
+    insertLineBreakCommand();
     typeCharacterCommand();
 }
 
index c61f451..b467799 100644 (file)
@@ -15,7 +15,7 @@
 function editingTest() {
     for (i = 0; i < 3; i++)
         moveSelectionForwardByCharacterCommand();
-    insertNewlineCommand();
+    insertLineBreakCommand();
 }
 
 </script>
index d47ecbd..0616151 100644 (file)
@@ -13,7 +13,7 @@
 <script>
 
 function editingTest() {
-    insertNewlineCommand();
+    insertLineBreakCommand();
     typeCharacterCommand(" ");
 }
 
index 53eff5b..9f67055 100644 (file)
@@ -13,7 +13,7 @@
 <script>
 
 function editingTest() {
-    insertNewlineCommand();
+    insertLineBreakCommand();
     typeCharacterCommand('\t');
 }
 
index fbed7e3..0cb607d 100644 (file)
@@ -1,3 +1,4 @@
+
 <html> 
 <head>
 
@@ -23,10 +24,10 @@ function moveNSpacesAndType(n) {
 
 function editingTest() {
     moveNSpacesAndType(4);
-    insertNewlineCommand();
+    insertLineBreakCommand();
     moveNSpacesAndType(4);
-    insertNewlineCommand();
-    insertNewlineCommand();
+    insertLineBreakCommand();
+    insertLineBreakCommand();
     moveNSpacesAndType(4);
 }
 
index 95ff47c..bd39890 100644 (file)
@@ -1,3 +1,4 @@
+
 <html> 
 <head>
 
@@ -22,8 +23,8 @@ function editingTest() {
         extendSelectionForwardByCharacterCommand();
     copyCommand();
     moveSelectionForwardByCharacterCommand();
-    insertNewlineCommand();
-    insertNewlineCommand();
+    insertLineBreakCommand();
+    insertLineBreakCommand();
     pasteCommand();
     pasteCommand();
 }
index 4d93527..1a119a8 100644 (file)
@@ -1,3 +1,33 @@
+2004-12-03  Ken Kocienda  <kocienda@apple.com>
+
+        Reviewed by John
+
+        Terminology change in execCommand command identifiers. Specifically, the name of 
+        "InsertNewline" command has been changed to "InsertLineBreak". This matches the 
+        terminology used by AppKit. It is also more accurate, since the insertion of a
+        "br" element is what the command does. The inspiration for this change is so the 
+        -insertNewline AppKit method can be mapped to insert a new "div" element in 
+        a document and avoid ambiguity with what the javascript editing command does.
+        
+        * khtml/editing/jsediting.cpp
+        * layout-tests/editing/deleting/delete-tab-004.html
+        * layout-tests/editing/editing.js
+        * layout-tests/editing/inserting/insert-3654864-fix.html
+        * layout-tests/editing/inserting/insert-3659587-fix.html
+        * layout-tests/editing/inserting/insert-3775316-fix.html
+        * layout-tests/editing/inserting/insert-3800346-fix.html
+        * layout-tests/editing/inserting/insert-br-001.html
+        * layout-tests/editing/inserting/insert-br-002.html
+        * layout-tests/editing/inserting/insert-br-003.html
+        * layout-tests/editing/inserting/insert-br-004.html
+        * layout-tests/editing/inserting/insert-br-005.html
+        * layout-tests/editing/inserting/insert-br-006.html
+        * layout-tests/editing/inserting/insert-br-007.html
+        * layout-tests/editing/inserting/insert-br-008.html
+        * layout-tests/editing/inserting/insert-tab-004.html
+        * layout-tests/editing/inserting/insert-text-with-newlines.html
+        * layout-tests/editing/pasteboard/paste-text-010.html
+
 2004-12-02  Ken Kocienda  <kocienda@apple.com>
 
         Reviewed by John
index b473dec..359cd16 100644 (file)
@@ -235,7 +235,7 @@ bool execIndent(KHTMLPart *part, bool userInterface, const DOMString &value)
     return false;
 }
 
-bool execInsertNewline(KHTMLPart *part, bool userInterface, const DOMString &value)
+bool execInsertLineBreak(KHTMLPart *part, bool userInterface, const DOMString &value)
 {
     TypingCommand::insertLineBreak(part->xmlDocImpl());
     return true;
@@ -471,7 +471,7 @@ QDict<CommandImp> createCommandDictionary()
         { "FontSize", { execFontSize, enabledAnySelection, stateNone, valueFontSize } },
         { "ForeColor", { execForeColor, enabledAnySelection, stateNone, valueForeColor } },
         { "Indent", { execIndent, enabledAnySelection, stateNone, valueNull } },
-        { "InsertNewline", { execInsertNewline, enabledAnySelection, stateNone, valueNull } },
+        { "InsertLineBreak", { execInsertLineBreak, enabledAnySelection, stateNone, valueNull } },
         { "InsertParagraph", { execInsertParagraph, enabledAnySelection, stateNone, valueNull } },
         { "InsertText", { execInsertText, enabledAnySelection, stateNone, valueNull } },
         { "Italic", { execItalic, enabledAnySelection, stateItalic, valueNull } },