Debug crash logs are not fully symbolicated on Yosemite
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 15 Jun 2016 01:45:25 +0000 (01:45 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 15 Jun 2016 01:45:25 +0000 (01:45 +0000)
https://bugs.webkit.org/show_bug.cgi?id=158760

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
for debug builds on Yosemite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
Tools/ChangeLog

index ec4ee69..7664b4e 100644 (file)
@@ -219,7 +219,9 @@ class CompileWebKit(shell.Compile):
             self.setCommand(self.command + ['ARCHS=' + architecture])
             if platform == 'ios':
                 self.setCommand(self.command + ['ONLY_ACTIVE_ARCH=NO'])
-        if platform in ('mac', 'ios') and buildOnly:
+        # Generating dSYM files is slow, but these are needed to have line numbers in crash reports on testers.
+        # Debug builds on Yosemite can't use dSYMs, because crash logs end up unsymbolicated.
+        if platform in ('mac', 'ios') and buildOnly and (fullPlatform != "mac-yosemite" || configuration != "debug"):
             self.setCommand(self.command + ['DEBUG_INFORMATION_FORMAT=dwarf-with-dsym'])
 
         appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))
index 524fd37..0f1536b 100644 (file)
@@ -1,5 +1,15 @@
 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
 
+        Debug crash logs are not fully symbolicated on Yosemite
+        https://bugs.webkit.org/show_bug.cgi?id=158760
+
+        Reviewed by Darin Adler.
+
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
+        for debug builds on Yosemite.
+
+2016-06-14  Alexey Proskuryakov  <ap@apple.com>
+
         Tests don't work in iOS Simulator when ASan is enabled
         https://bugs.webkit.org/show_bug.cgi?id=158726