Web Inspector: Uncaught Exceptions when attempting to show Content Flow

https://bugs.webkit.org/show_bug.cgi?id=139276

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-12-05
Reviewed by Brian Burg.

* UserInterface/Views/ContentView.js:
(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
LegacyJavaScriptProfileObject no longer exists, these references should be removed.

* UserInterface/Views/FolderizedTreeElement.js:
(WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
This sort function references "this" and needed to be bound.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
index 228ad49..6bd6d77 100644 (file)
--- a/Source/WebInspectorUI/ChangeLog
+++ b/Source/WebInspectorUI/ChangeLog
@@ -1,3 +1,19 @@
+2014-12-05  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Uncaught Exceptions when attempting to show Content Flow
+        https://bugs.webkit.org/show_bug.cgi?id=139276
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/ContentView.js:
+        (WebInspector.ContentView):
+        (WebInspector.ContentView.isViewable):
+        LegacyJavaScriptProfileObject no longer exists, these references should be removed.
+
+        * UserInterface/Views/FolderizedTreeElement.js:
+        (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
+        This sort function references "this" and needed to be bound.
+
 2014-12-04  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters

diff --git a/Source/WebInspectorUI/UserInterface/Views/ContentView.js b/Source/WebInspectorUI/UserInterface/Views/ContentView.js
index 691f83a..6d784a8 100644 (file)
--- a/Source/WebInspectorUI/UserInterface/Views/ContentView.js
+++ b/Source/WebInspectorUI/UserInterface/Views/ContentView.js
@@ -69,9 +69,6 @@ WebInspector.ContentView = function(representedObject)
         if (representedObject instanceof WebInspector.LogObject)
             return new WebInspector.LogContentView(representedObject);
 
-        if (representedObject instanceof WebInspector.LegacyJavaScriptProfileObject)
-            return new WebInspector.LegacyJavaScriptProfileView(representedObject);
-
         if (representedObject instanceof WebInspector.ContentFlow)
             return new WebInspector.ContentFlowDOMTreeContentView(representedObject);
 
@@ -127,8 +124,6 @@ WebInspector.ContentView.isViewable = function(representedObject)
         return true;
     if (representedObject instanceof WebInspector.LogObject)
         return true;
-    if (representedObject instanceof WebInspector.LegacyJavaScriptProfileObject)
-        return true;
     if (representedObject instanceof WebInspector.ContentFlow)
         return true;
     if (typeof representedObject === "string" || representedObject instanceof String)

diff --git a/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js b/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js
index 2dac1dc..0fe62a8 100644 (file)
--- a/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js
+++ b/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js
@@ -237,7 +237,7 @@ WebInspector.FolderizedTreeElement.prototype = {
     _insertChildTreeElement: function(parentTreeElement, childTreeElement)
     {
         console.assert(!childTreeElement.parent);
-        parentTreeElement.insertChild(childTreeElement, insertionIndexForObjectInListSortedByFunction(childTreeElement, parentTreeElement.children, this.compareChildTreeElements));
+        parentTreeElement.insertChild(childTreeElement, insertionIndexForObjectInListSortedByFunction(childTreeElement, parentTreeElement.children, this.compareChildTreeElements.bind(this)));
     },
 
     _removeTreeElement: function(childTreeElement, suppressOnDeselect, suppressSelectSibling)