2009-06-17 Eric Carlson <eric.carlson@apple.com>
authoreric.carlson@apple.com <eric.carlson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 Jun 2009 18:21:04 +0000 (18:21 +0000)
committereric.carlson@apple.com <eric.carlson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 Jun 2009 18:21:04 +0000 (18:21 +0000)
        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=26482
        <rdar://problem/6978590> When setting playback rate to 0, the audio element stops
        playing (doesn't resume later)

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::setRate): Always set the rate, even when "paused".

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::setRate): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm
WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp

index 648c20a..f852077 100644 (file)
@@ -1,3 +1,17 @@
+2009-06-17  Eric Carlson  <eric.carlson@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        https://bugs.webkit.org/show_bug.cgi?id=26482
+        <rdar://problem/6978590> When setting playback rate to 0, the audio element stops 
+        playing (doesn't resume later)
+
+        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+        (WebCore::MediaPlayerPrivate::setRate): Always set the rate, even when "paused".
+
+        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
+        (WebCore::MediaPlayerPrivate::setRate): Ditto.
+
 2009-06-17  Adam Roben  <aroben@apple.com>
 
         Add all the generated JS*.cpp files back to WebCore.vcproj
index ab9cd3d..806ec5e 100644 (file)
@@ -607,8 +607,7 @@ void MediaPlayerPrivate::setRate(float rate)
 {
     if (!metaDataAvailable())
         return;
-    if (!paused())
-        [m_qtMovie.get() setRate:rate];
+    [m_qtMovie.get() setRate:rate];
 }
 
 int MediaPlayerPrivate::dataRate() const
index 35ea786..9312362 100644 (file)
@@ -252,8 +252,7 @@ void MediaPlayerPrivate::setRate(float rate)
 {
     if (!m_qtMovie)
         return;
-    if (!paused())
-        m_qtMovie->setRate(rate);
+    m_qtMovie->setRate(rate);
 }
 
 int MediaPlayerPrivate::dataRate() const