Fix uninitialized public members in WTF

https://bugs.webkit.org/show_bug.cgi?id=169676

Reviewed by Michael Catanzaro.

Found by Coverity scan.

* wtf/Bag.h:
* wtf/HashTable.h:
* wtf/HashTraits.h:
* wtf/Insertion.h:
* wtf/OrderMaker.h:
* wtf/ParallelJobsGeneric.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@214299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
index 34e8f6c..4042cb3 100644 (file)
--- a/Source/WTF/ChangeLog
+++ b/Source/WTF/ChangeLog
@@ -1,3 +1,19 @@
+2017-03-23  Tomas Popela  <tpopela@redhat.com>
+
+        Fix uninitialized public members in WTF
+        https://bugs.webkit.org/show_bug.cgi?id=169676
+
+        Reviewed by Michael Catanzaro.
+
+        Found by Coverity scan.
+
+        * wtf/Bag.h:
+        * wtf/HashTable.h:
+        * wtf/HashTraits.h:
+        * wtf/Insertion.h:
+        * wtf/OrderMaker.h:
+        * wtf/ParallelJobsGeneric.h:
+
 2017-03-22  Andreas Kling  <akling@apple.com>
 
         Let MemoryPressureHandler track whether the process is active or inactive.

diff --git a/Source/WTF/wtf/Bag.h b/Source/WTF/wtf/Bag.h
index 01eca74..2d02620 100644 (file)
--- a/Source/WTF/wtf/Bag.h
+++ b/Source/WTF/wtf/Bag.h
@@ -43,7 +43,7 @@ private:
         }
         
         T m_item;
-        Node* m_next;
+        Node* m_next { nullptr };
     };
     
 public:

diff --git a/Source/WTF/wtf/HashTable.h b/Source/WTF/wtf/HashTable.h
index a576e62..7f4fa9f 100644 (file)
--- a/Source/WTF/wtf/HashTable.h
+++ b/Source/WTF/wtf/HashTable.h
@@ -225,8 +225,8 @@ namespace WTF {
         void checkValidity(const const_iterator&) const { }
 #endif
 
-        PointerType m_position;
-        PointerType m_endPosition;
+        PointerType m_position { nullptr };
+        PointerType m_endPosition { nullptr };
 
 #if CHECK_HASHTABLE_ITERATORS
     public:

diff --git a/Source/WTF/wtf/HashTraits.h b/Source/WTF/wtf/HashTraits.h
index 323cea0..aa53e72 100644 (file)
--- a/Source/WTF/wtf/HashTraits.h
+++ b/Source/WTF/wtf/HashTraits.h
@@ -302,7 +302,7 @@ struct KeyValuePair {
     }
 
     KeyTypeArg key;
-    ValueTypeArg value;
+    ValueTypeArg value { };
 };
 
 template<typename KeyTraitsArg, typename ValueTraitsArg>

diff --git a/Source/WTF/wtf/Insertion.h b/Source/WTF/wtf/Insertion.h
index 901d8bb..8a287a0 100644 (file)
--- a/Source/WTF/wtf/Insertion.h
+++ b/Source/WTF/wtf/Insertion.h
@@ -50,8 +50,8 @@ public:
     }
     
 private:
-    size_t m_index;
-    T m_element;
+    size_t m_index { 0 };
+    T m_element { };
 };
 
 template<typename TargetVectorType, typename InsertionVectorType>

diff --git a/Source/WTF/wtf/OrderMaker.h b/Source/WTF/wtf/OrderMaker.h
index 12c9de0..7089777 100644 (file)
--- a/Source/WTF/wtf/OrderMaker.h
+++ b/Source/WTF/wtf/OrderMaker.h
@@ -50,7 +50,7 @@ class OrderMaker {
         {
         }
 
-        T payload;
+        T payload { };
     };
     
 public:

diff --git a/Source/WTF/wtf/ParallelJobsGeneric.h b/Source/WTF/wtf/ParallelJobsGeneric.h
index 52f4799..458407c 100644 (file)
--- a/Source/WTF/wtf/ParallelJobsGeneric.h
+++ b/Source/WTF/wtf/ParallelJobsGeneric.h
@@ -81,8 +81,8 @@ public:
         mutable Lock m_mutex;
         Condition m_threadCondition;
 
-        ThreadFunction m_threadFunction;
-        void* m_parameters;
+        ThreadFunction m_threadFunction { nullptr };
+        void* m_parameters { nullptr };
     };
 
 private: