fix style failures in webkitpy: multiple statements on one line (semicolon)
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Nov 2017 17:46:22 +0000 (17:46 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Nov 2017 17:46:22 +0000 (17:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=179530

Reviewed by Alex Christensen.

* Scripts/webkitpy/common/net/buildbot/buildbot.py: Removed semicolon.
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Ditto.
* Scripts/webkitpy/tool/steps/runtests.py: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py
Tools/Scripts/webkitpy/tool/steps/runtests.py

index a6abc9f..6d06426 100644 (file)
@@ -1,5 +1,16 @@
 2017-11-10  Aakash Jain  <aakash_jain@apple.com>
 
+        fix style failures in webkitpy: multiple statements on one line (semicolon)
+        https://bugs.webkit.org/show_bug.cgi?id=179530
+
+        Reviewed by Alex Christensen.
+
+        * Scripts/webkitpy/common/net/buildbot/buildbot.py: Removed semicolon.
+        * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Ditto.
+        * Scripts/webkitpy/tool/steps/runtests.py: Ditto.
+
+2017-11-10  Aakash Jain  <aakash_jain@apple.com>
+
         fix style failures in webkitpy: expected 2 blank lines found 1
         https://bugs.webkit.org/show_bug.cgi?id=179529
 
index bce7968..097a1fd 100644 (file)
@@ -66,7 +66,7 @@ class Builder(object):
         return None
 
     def latest_layout_test_results_url(self):
-        return self.accumulated_results_url() or self.latest_cached_build().results_url();
+        return self.accumulated_results_url() or self.latest_cached_build().results_url()
 
     @memoized
     def latest_layout_test_results(self):
index d47e6b9..8671c5e 100644 (file)
@@ -190,13 +190,13 @@ class TestResultWriter(object):
 
         base_dir = self._port.path_from_webkit_base('LayoutTests', 'fast', 'harness')
 
-        image_diff_template = self._filesystem.join(base_dir, 'image-diff-template.html');
+        image_diff_template = self._filesystem.join(base_dir, 'image-diff-template.html')
         image_diff_file = ""
         if self._filesystem.exists(image_diff_template):
             image_diff_file = self._filesystem.read_text_file(image_diff_template)
 
-        html = image_diff_file.replace('__TITLE__', self._test_name);
-        html = html.replace('__PREFIX__', self._output_testname(''));
+        html = image_diff_file.replace('__TITLE__', self._test_name)
+        html = html.replace('__PREFIX__', self._output_testname(''))
 
         diffs_html_filename = self.output_filename(self.FILENAME_SUFFIX_IMAGE_DIFFS_HTML)
         self._filesystem.write_text_file(diffs_html_filename, html)
index f45da55..09ebf78 100644 (file)
@@ -136,7 +136,7 @@ class RunTests(AbstractStep):
                 args.append("--quiet")
                 args.append("--skip-failing-tests")
             else:
-                args.append("--no-build");
+                args.append("--no-build")
 
         if self._options.quiet:
             args.append("--quiet")