CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_subl...
authordino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 8 Oct 2018 23:19:25 +0000 (23:19 +0000)
committerdino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 8 Oct 2018 23:19:25 +0000 (23:19 +0000)
https://bugs.webkit.org/show_bug.cgi?id=190376
<rdar://problem/44986520>

Reviewed by Tim Horton.

Source/WebCore:

Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
depth from 256 to 128.

Modified existing test: compositing/layer-creation/deep-tree.html

* platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.

LayoutTests:

* compositing/layer-creation/deep-tree.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/compositing/layer-creation/deep-tree.html
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

index 2535fdd..ffa3f75 100644 (file)
@@ -1,3 +1,13 @@
+2018-10-08  Dean Jackson  <dino@apple.com>
+
+        CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+        https://bugs.webkit.org/show_bug.cgi?id=190376
+        <rdar://problem/44986520>
+
+        Reviewed by Tim Horton.
+
+        * compositing/layer-creation/deep-tree.html:
+
 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
 
         Make <input type=color> a runtime enabled (on-by-default) feature
index 4d7bca3..efce211 100644 (file)
@@ -33,7 +33,7 @@
         
         function doTest()
         {
-            makeDeepTree(500, document.getElementById('deep'));
+            makeDeepTree(129, document.getElementById('deep'));
         }
         
         window.addEventListener('load', doTest, false);
index 1e4909d..3bfa89c 100644 (file)
@@ -1,3 +1,18 @@
+2018-10-08  Dean Jackson  <dino@apple.com>
+
+        CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+        https://bugs.webkit.org/show_bug.cgi?id=190376
+        <rdar://problem/44986520>
+
+        Reviewed by Tim Horton.
+
+        Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
+        depth from 256 to 128.
+
+        Modified existing test: compositing/layer-creation/deep-tree.html
+
+        * platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
+
 2018-10-08  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r236941.
index a219d64..a627b09 100644 (file)
@@ -89,7 +89,7 @@ static const int cMaxPixelDimension = 2048;
 #endif
 
 // Derived empirically: <rdar://problem/13401861>
-static const unsigned cMaxLayerTreeDepth = 250;
+static const unsigned cMaxLayerTreeDepth = 128;
 
 // About 10 screens of an iPhone 6 Plus. <rdar://problem/44532782>
 static const unsigned cMaxTotalBackdropFilterArea = 1242 * 2208 * 10;