Dashboard: Remove duplicate gear icon data URLs
authordbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 8 Sep 2015 15:57:58 +0000 (15:57 +0000)
committerdbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 8 Sep 2015 15:57:58 +0000 (15:57 +0000)
https://bugs.webkit.org/show_bug.cgi?id=148920

Reviewed by Alexey Proskuryakov.

Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
background-image associated with each of the three gear icon states: collapsed (.settings), hover
(.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
as a mask and make use of the CSS background-color to define the fill color for each of these three
states.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(.settings): Use gear icon as mask and define CSS background-color for collapsed state.
(.settings:hover): Override CSS background-color for hover state.
(.settings-visible .settings): Override CSS background-color for expanded state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css
Tools/ChangeLog

index cb7a1e7..9558323 100644 (file)
@@ -75,16 +75,17 @@ div.cellButton.unhide, div.accessibilityButton.unhide {
     left: 5px;
     width: 35px;
     height: 35px;
-    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 250 250"><path fill="rgb(166, 158, 130)" d="M213,144v-39h-21.055c-1.476-5-3.51-10.085-6.051-14.668l14.673-14.697l-27.578-27.589l-14.521,14.665 C153.885,60.17,149,58.13,144,56.654V36h-39v20.654c-5,1.476-10.186,3.51-14.769,6.051L75.484,48.033L47.869,75.609l14.652,14.723 C59.981,94.915,57.929,100,56.453,105H36v39h20.453c1.476,5,3.511,9.985,6.051,14.569l-14.672,14.646l27.577,27.565l14.822-14.679 c4.583,2.541,9.769,4.569,14.769,6.045V213h39v-20.854c5-1.476,9.885-3.51,14.468-6.051l14.597,14.672l27.541-27.576l-14.691-14.623 c2.54-4.583,4.556-9.568,6.031-14.568H213z M124.199,164.9c-22.367,0-40.5-18.133-40.5-40.5s18.133-40.5,40.5-40.5 s40.5,18.133,40.5,40.5S146.566,164.9,124.199,164.9z"/></svg>');
+    background-color: rgb(166, 158, 130);
+    -webkit-mask-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 250 250"><path d="M213,144v-39h-21.055c-1.476-5-3.51-10.085-6.051-14.668l14.673-14.697l-27.578-27.589l-14.521,14.665 C153.885,60.17,149,58.13,144,56.654V36h-39v20.654c-5,1.476-10.186,3.51-14.769,6.051L75.484,48.033L47.869,75.609l14.652,14.723 C59.981,94.915,57.929,100,56.453,105H36v39h20.453c1.476,5,3.511,9.985,6.051,14.569l-14.672,14.646l27.577,27.565l14.822-14.679 c4.583,2.541,9.769,4.569,14.769,6.045V213h39v-20.854c5-1.476,9.885-3.51,14.468-6.051l14.597,14.672l27.541-27.576l-14.691-14.623 c2.54-4.583,4.556-9.568,6.031-14.568H213z M124.199,164.9c-22.367,0-40.5-18.133-40.5-40.5s18.133-40.5,40.5-40.5 s40.5,18.133,40.5,40.5S146.566,164.9,124.199,164.9z"/></svg>');
     cursor: pointer;
 }
 
 .settings:hover {
-    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 250 250"><path fill="rgb(185, 175, 125)" d="M213,144v-39h-21.055c-1.476-5-3.51-10.085-6.051-14.668l14.673-14.697l-27.578-27.589l-14.521,14.665 C153.885,60.17,149,58.13,144,56.654V36h-39v20.654c-5,1.476-10.186,3.51-14.769,6.051L75.484,48.033L47.869,75.609l14.652,14.723 C59.981,94.915,57.929,100,56.453,105H36v39h20.453c1.476,5,3.511,9.985,6.051,14.569l-14.672,14.646l27.577,27.565l14.822-14.679 c4.583,2.541,9.769,4.569,14.769,6.045V213h39v-20.854c5-1.476,9.885-3.51,14.468-6.051l14.597,14.672l27.541-27.576l-14.691-14.623 c2.54-4.583,4.556-9.568,6.031-14.568H213z M124.199,164.9c-22.367,0-40.5-18.133-40.5-40.5s18.133-40.5,40.5-40.5 s40.5,18.133,40.5,40.5S146.566,164.9,124.199,164.9z"/></svg>');
+    background-color: rgb(185, 175, 125);
 }
 
 .settings-visible .settings {
-    background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 250 250"><path fill="rgb(76, 151, 61)" d="M213,144v-39h-21.055c-1.476-5-3.51-10.085-6.051-14.668l14.673-14.697l-27.578-27.589l-14.521,14.665 C153.885,60.17,149,58.13,144,56.654V36h-39v20.654c-5,1.476-10.186,3.51-14.769,6.051L75.484,48.033L47.869,75.609l14.652,14.723 C59.981,94.915,57.929,100,56.453,105H36v39h20.453c1.476,5,3.511,9.985,6.051,14.569l-14.672,14.646l27.577,27.565l14.822-14.679 c4.583,2.541,9.769,4.569,14.769,6.045V213h39v-20.854c5-1.476,9.885-3.51,14.468-6.051l14.597,14.672l27.541-27.576l-14.691-14.623 c2.54-4.583,4.556-9.568,6.031-14.568H213z M124.199,164.9c-22.367,0-40.5-18.133-40.5-40.5s18.133-40.5,40.5-40.5 s40.5,18.133,40.5,40.5S146.566,164.9,124.199,164.9z"/></svg>');
+    background-color: rgb(76, 151, 61);
 }
 
 body {
index 897c509..ca9d76e 100644 (file)
@@ -1,3 +1,21 @@
+2015-09-08  Daniel Bates  <dabates@apple.com>
+
+        Dashboard: Remove duplicate gear icon data URLs
+        https://bugs.webkit.org/show_bug.cgi?id=148920
+
+        Reviewed by Alexey Proskuryakov.
+
+        Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
+        background-image associated with each of the three gear icon states: collapsed (.settings), hover
+        (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
+        as a mask and make use of the CSS background-color to define the fill color for each of these three
+        states.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+        (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
+        (.settings:hover): Override CSS background-color for hover state.
+        (.settings-visible .settings): Override CSS background-color for expanded state.
+
 2015-09-07  Andy Estes  <aestes@apple.com>
 
         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11